Re: [PATCH] drbd: fix request leak introduced by locking/atomic, kref: Kill kref_sub()

2017-05-11 Thread Jens Axboe
On 05/11/2017 02:21 AM, Lars Ellenberg wrote: > Regression fix for 4.11, which totally broke DRBD > > When killing kref_sub(), the unconditional additional kref_get() > was not properly paired with the necessary kref_put(), causing > a leak of struct drbd_requests (~ 224 Bytes) per submitted bio,

[PATCH] drbd: fix request leak introduced by locking/atomic, kref: Kill kref_sub()

2017-05-11 Thread Lars Ellenberg
Regression fix for 4.11, which totally broke DRBD When killing kref_sub(), the unconditional additional kref_get() was not properly paired with the necessary kref_put(), causing a leak of struct drbd_requests (~ 224 Bytes) per submitted bio, and breaking DRBD in general, as the destructor of those

Re: [PATCH] drbd: fix request leak introduced by locking/atomic, kref: Kill kref_sub()

2017-05-11 Thread Peter Zijlstra
On Thu, May 11, 2017 at 10:21:46AM +0200, Lars Ellenberg wrote: > Regression fix for 4.11, which totally broke DRBD > > When killing kref_sub(), the unconditional additional kref_get() > was not properly paired with the necessary kref_put(), causing > a leak of struct drbd_requests (~ 224 Bytes) p