Re: [PATCH] drbd: avoid clang warning about pointless switch statement

2018-09-12 Thread Arnd Bergmann
On Wed, Sep 12, 2018 at 12:01 PM Philipp Klocke wrote: > > Hello, > > I've also stumbled across the "warning: no case matching constant switch > condition '0'" and wanted to fix it. > As your suggestion is probably the best way, I wanted to ask why it > didn't get merged yet. > > Maybe the patch g

Re: [PATCH] drbd: avoid clang warning about pointless switch statement

2018-09-12 Thread Philipp Klocke
Hello, I've also stumbled across the "warning: no case matching constant switch condition '0'" and wanted to fix it. As your suggestion is probably the best way, I wanted to ask why it didn't get merged yet. Maybe the patch got lost? Best regards, Philipp

Re: [PATCH] drbd: avoid clang warning about pointless switch statement

2017-02-06 Thread Lars Ellenberg
Ack. Ok, not exactly "pintless", it's a valid compile time assert for uniq ids, basically a BUILD_BUG_ON(duplicate-ids). But adding a default clause there does not hurt. Thanks, Lars On Wed, Feb 01, 2017 at 05:55:02PM +0100, Arnd Bergmann wrote: > The drbd code causes warnings that we canno

[PATCH] drbd: avoid clang warning about pointless switch statement

2017-02-01 Thread Arnd Bergmann
The drbd code causes warnings that we cannot easily disable when building with clang: In file included from drivers/block/drbd/drbd_debugfs.c:10: In file included from drivers/block/drbd/drbd_int.h:48: In file included from include/linux/drbd_genl_api.h:53: In file included from include/linux/gen