Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-29 Thread Michal Hocko
On Mon 28-05-18 10:21:00, Nikolay Borisov wrote: > > > On 25.05.2018 10:52, Michal Hocko wrote: > > On Thu 24-05-18 09:37:18, Randy Dunlap wrote: > >> On 05/24/2018 04:43 AM, Michal Hocko wrote: > > [...] > >>> +The traditional way to avoid this deadlock problem is to clear __GFP_FS > >>> +resp.

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-29 Thread Michal Hocko
On Mon 28-05-18 09:10:43, Randy Dunlap wrote: > On 05/28/2018 02:21 AM, Michal Hocko wrote: [...] > > +reclaim context or when a transaction context nesting would be possible > > +via reclaim. The corresponding restore function when the critical > > "The corresponding restore ... ends." << That i

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-29 Thread Michal Hocko
On Tue 29-05-18 08:32:05, Dave Chinner wrote: > On Mon, May 28, 2018 at 11:19:23AM +0200, Michal Hocko wrote: > > On Mon 28-05-18 09:48:54, Dave Chinner wrote: > > > On Fri, May 25, 2018 at 10:16:24AM +0200, Michal Hocko wrote: > > > > On Fri 25-05-18 08:17:15, Dave Chinner wrote: > > > > > On Thu,

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-28 Thread Dave Chinner
On Mon, May 28, 2018 at 11:19:23AM +0200, Michal Hocko wrote: > On Mon 28-05-18 09:48:54, Dave Chinner wrote: > > On Fri, May 25, 2018 at 10:16:24AM +0200, Michal Hocko wrote: > > > On Fri 25-05-18 08:17:15, Dave Chinner wrote: > > > > On Thu, May 24, 2018 at 01:43:41PM +0200, Michal Hocko wrote: >

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-28 Thread Randy Dunlap
On 05/28/2018 02:21 AM, Michal Hocko wrote: > On Sun 27-05-18 15:47:22, Mike Rapoport wrote: >> On Fri, May 25, 2018 at 10:16:24AM +0200, Michal Hocko wrote: >>> On Fri 25-05-18 08:17:15, Dave Chinner wrote: On Thu, May 24, 2018 at 01:43:41PM +0200, Michal Hocko wrote: >>> [...] > +FS/IO c

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-28 Thread Vlastimil Babka
On 05/25/2018 09:52 AM, Michal Hocko wrote: > On Thu 24-05-18 09:37:18, Randy Dunlap wrote: >> On 05/24/2018 04:43 AM, Michal Hocko wrote: > [...] >>> +The traditional way to avoid this deadlock problem is to clear __GFP_FS >>> +resp. __GFP_IO (note the later implies clearing the first as well) in

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-28 Thread Michal Hocko
On Mon 28-05-18 09:48:54, Dave Chinner wrote: > On Fri, May 25, 2018 at 10:16:24AM +0200, Michal Hocko wrote: > > On Fri 25-05-18 08:17:15, Dave Chinner wrote: > > > On Thu, May 24, 2018 at 01:43:41PM +0200, Michal Hocko wrote: > > [...] > > > > +FS/IO code then simply calls the appropriate save fu

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-28 Thread Michal Hocko
On Sun 27-05-18 15:47:22, Mike Rapoport wrote: > On Fri, May 25, 2018 at 10:16:24AM +0200, Michal Hocko wrote: > > On Fri 25-05-18 08:17:15, Dave Chinner wrote: > > > On Thu, May 24, 2018 at 01:43:41PM +0200, Michal Hocko wrote: > > [...] > > > > +FS/IO code then simply calls the appropriate save f

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-28 Thread Nikolay Borisov
On 25.05.2018 10:52, Michal Hocko wrote: > On Thu 24-05-18 09:37:18, Randy Dunlap wrote: >> On 05/24/2018 04:43 AM, Michal Hocko wrote: > [...] >>> +The traditional way to avoid this deadlock problem is to clear __GFP_FS >>> +resp. __GFP_IO (note the later implies clearing the first as well) in >

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-27 Thread Dave Chinner
On Fri, May 25, 2018 at 10:16:24AM +0200, Michal Hocko wrote: > On Fri 25-05-18 08:17:15, Dave Chinner wrote: > > On Thu, May 24, 2018 at 01:43:41PM +0200, Michal Hocko wrote: > [...] > > > +FS/IO code then simply calls the appropriate save function right at the > > > +layer where a lock taken from

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-27 Thread Mike Rapoport
On Fri, May 25, 2018 at 10:16:24AM +0200, Michal Hocko wrote: > On Fri 25-05-18 08:17:15, Dave Chinner wrote: > > On Thu, May 24, 2018 at 01:43:41PM +0200, Michal Hocko wrote: > [...] > > > +FS/IO code then simply calls the appropriate save function right at the > > > +layer where a lock taken from

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-25 Thread Michal Hocko
On Fri 25-05-18 08:17:15, Dave Chinner wrote: > On Thu, May 24, 2018 at 01:43:41PM +0200, Michal Hocko wrote: [...] > > +FS/IO code then simply calls the appropriate save function right at the > > +layer where a lock taken from the reclaim context (e.g. shrinker) and > > +the corresponding restore

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-25 Thread Michal Hocko
On Thu 24-05-18 14:52:02, Jonathan Corbet wrote: > On Thu, 24 May 2018 13:43:41 +0200 > Michal Hocko wrote: > > > From: Michal Hocko > > > > Although the api is documented in the source code Ted has pointed out > > that there is no mention in the core-api Documentation and there are > > people

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-25 Thread Michal Hocko
On Thu 24-05-18 09:37:18, Randy Dunlap wrote: > On 05/24/2018 04:43 AM, Michal Hocko wrote: [...] > > +The traditional way to avoid this deadlock problem is to clear __GFP_FS > > +resp. __GFP_IO (note the later implies clearing the first as well) in > > latter ? No I r

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-24 Thread Theodore Y. Ts'o
On Fri, May 25, 2018 at 08:17:15AM +1000, Dave Chinner wrote: > On Thu, May 24, 2018 at 01:43:41PM +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > Although the api is documented in the source code Ted has pointed out > > that there is no mention in the core-api Documentation and there a

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-24 Thread Dave Chinner
On Thu, May 24, 2018 at 01:43:41PM +0200, Michal Hocko wrote: > From: Michal Hocko > > Although the api is documented in the source code Ted has pointed out > that there is no mention in the core-api Documentation and there are > people looking there to find answers how to use a specific API. >

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-24 Thread Jonathan Corbet
On Thu, 24 May 2018 13:43:41 +0200 Michal Hocko wrote: > From: Michal Hocko > > Although the api is documented in the source code Ted has pointed out > that there is no mention in the core-api Documentation and there are > people looking there to find answers how to use a specific API. > > Cc:

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-24 Thread Randy Dunlap
On 05/24/2018 04:43 AM, Michal Hocko wrote: > From: Michal Hocko > > Although the api is documented in the source code Ted has pointed out > that there is no mention in the core-api Documentation and there are > people looking there to find answers how to use a specific API. > > Cc: "Darrick J.

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-24 Thread Michal Hocko
On Thu 24-05-18 07:33:39, Shakeel Butt wrote: > On Thu, May 24, 2018 at 4:43 AM, Michal Hocko wrote: [...] > > +The traditional way to avoid this deadlock problem is to clear __GFP_FS > > +resp. __GFP_IO (note the later implies clearing the first as well) in > > Is resp. == respectively? Why not

Re: [PATCH] doc: document scope NOFS, NOIO APIs

2018-05-24 Thread Shakeel Butt
On Thu, May 24, 2018 at 4:43 AM, Michal Hocko wrote: > From: Michal Hocko > > Although the api is documented in the source code Ted has pointed out > that there is no mention in the core-api Documentation and there are > people looking there to find answers how to use a specific API. > > Cc: "Dar

[PATCH] doc: document scope NOFS, NOIO APIs

2018-05-24 Thread Michal Hocko
From: Michal Hocko Although the api is documented in the source code Ted has pointed out that there is no mention in the core-api Documentation and there are people looking there to find answers how to use a specific API. Cc: "Darrick J. Wong" Cc: David Sterba Requested-by: "Theodore Y. Ts'o"