Re: [PATCH] doc: avoid strncpy in accounting tool

2013-06-10 Thread Andrew Morton
On Wed, 5 Jun 2013 19:49:30 -0700 Kees Cook wrote: > Avoid strncpy anti-pattern. Use strdup() instead, as already done for > the logfile optarg. > What Andreas said :) From: Andrew Morton Subject: documentation-accounting-getdelaysc-avoid-strncpy-in-accounting-tool-fix remove the str[cpy|du

Re: [PATCH] doc: avoid strncpy in accounting tool

2013-06-08 Thread Rob Landley
On 06/05/2013 09:49:30 PM, Kees Cook wrote: Avoid strncpy anti-pattern. Use strdup() instead, as already done for the logfile optarg. Signed-off-by: Kees Cook --- Fix for -mm clean-up-scary-strncpydst-src-strlensrc-uses-fix.patch --- Documentation/accounting/getdelays.c |4 ++-- 1 file cha

Re: [PATCH] doc: avoid strncpy in accounting tool

2013-06-06 Thread Andreas Schwab
Kees Cook writes: > Avoid strncpy anti-pattern. Use strdup() instead, as already done for > the logfile optarg. There should be no need to copy the string, option arguments are stable. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5

[PATCH] doc: avoid strncpy in accounting tool

2013-06-05 Thread Kees Cook
Avoid strncpy anti-pattern. Use strdup() instead, as already done for the logfile optarg. Signed-off-by: Kees Cook --- Fix for -mm clean-up-scary-strncpydst-src-strlensrc-uses-fix.patch --- Documentation/accounting/getdelays.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --