Re: [PATCH] do_signal_stop: use signal_group_exit()

2008-02-19 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > >>From 2.6.25-rc2-mm1.bz2 patch: >> >> - .ioctl = tty_ioctl, >> + .unlocked_ioctl = tty_ioctl, > > and this is why this didn't happen before, I guess. Right. Does anyone know what kind of audit was made of the tty code to ensure ev

Re: [PATCH] do_signal_stop: use signal_group_exit()

2008-02-19 Thread Valdis . Kletnieks
On Sun, 17 Feb 2008 21:11:14 MST, Eric W. Biederman said: > Oleg Nesterov <[EMAIL PROTECTED]> writes: > > On 02/16, Oleg Nesterov wrote: > >> On 02/15, Andrew Morton wrote: > >> > : BUG: unable to handle kernel paging request at 00200200 > >> > : Call Trace: > >> > : [] ? release_task+0x1

Re: [PATCH] do_signal_stop: use signal_group_exit()

2008-02-17 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > On 02/16, Oleg Nesterov wrote: >> >> On 02/15, Andrew Morton wrote: >> > >> > ug. On about the fourth boot with the current -mm lineup I hit: >> > >> > : BUG: unable to handle kernel paging request at 00200200 >>

Re: [PATCH] do_signal_stop: use signal_group_exit()

2008-02-17 Thread Oleg Nesterov
On 02/16, Oleg Nesterov wrote: > > On 02/15, Andrew Morton wrote: > > > > ug. On about the fourth boot with the current -mm lineup I hit: > > > > : BUG: unable to handle kernel paging request at 00200200 > > == LIST_POISON

Re: [PATCH] do_signal_stop: use signal_group_exit()

2008-02-16 Thread Oleg Nesterov
On 02/15, Andrew Morton wrote: > > ug. On about the fourth boot with the current -mm lineup I hit: > > : BUG: unable to handle kernel paging request at 00200200 == LIST_POISON2 > : IP: [] free_pid+0x35/0x8e most probably

Re: [PATCH] do_signal_stop: use signal_group_exit()

2008-02-15 Thread Andrew Morton
ug. On about the fourth boot with the current -mm lineup I hit: : security: permission sendto in class node not defined in policy : security: permission dccp_recv in class netif not defined in policy : security: permission dccp_send in class netif not defined in policy : security: permission

[PATCH] do_signal_stop: use signal_group_exit()

2008-02-15 Thread Oleg Nesterov
do_signal_stop() needs signal_group_exit() but checks sig->group_exit_task. This (optimization) is correct, SIGNAL_STOP_DEQUEUED and SIGNAL_GROUP_EXIT are mutually exclusive, but looks confusing. Use signal_group_exit(), this is not fastpath, the code clarity is more important. Signed-off-by: Oleg