Re: [PATCH] dmaengine: remove DBGFS_FUNC_DECL()

2018-12-05 Thread Frank Lee
On Wed, Dec 5, 2018 at 11:59 PM Vinod Koul wrote: > > On 05-12-18, 23:49, Frank Lee wrote: > > On Wed, Dec 5, 2018 at 4:27 PM Vinod Koul wrote: > > > > > > On 30-11-18, 10:42, Yangtao Li wrote: > > > > We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define > > > > such a macro,so re

Re: [PATCH] dmaengine: remove DBGFS_FUNC_DECL()

2018-12-05 Thread Vinod Koul
On 05-12-18, 23:49, Frank Lee wrote: > On Wed, Dec 5, 2018 at 4:27 PM Vinod Koul wrote: > > > > On 30-11-18, 10:42, Yangtao Li wrote: > > > We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define > > > such a macro,so remove DBGFS_FUNC_DECL.Also use macro to simplify some > > > code.

Re: [PATCH] dmaengine: remove DBGFS_FUNC_DECL()

2018-12-05 Thread Frank Lee
On Wed, Dec 5, 2018 at 4:27 PM Vinod Koul wrote: > > On 30-11-18, 10:42, Yangtao Li wrote: > > We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define > > such a macro,so remove DBGFS_FUNC_DECL.Also use macro to simplify some > > code. > > Spaces after full stop and comma please > > >

Re: [PATCH] dmaengine: remove DBGFS_FUNC_DECL()

2018-12-05 Thread Vinod Koul
On 30-11-18, 10:42, Yangtao Li wrote: > We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define > such a macro,so remove DBGFS_FUNC_DECL.Also use macro to simplify some > code. Spaces after full stop and comma please > > Signed-off-by: Yangtao Li > --- > drivers/dma/amba-pl08x.c

Re: [PATCH] dmaengine: remove DBGFS_FUNC_DECL()

2018-11-30 Thread Robert Jarzmik
Sinan Kaya writes: > On 11/30/2018 10:42 AM, Yangtao Li wrote: >> We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define >> such a macro,so remove DBGFS_FUNC_DECL.Also use macro to simplify some >> code. >> >> Signed-off-by: Yangtao Li >> --- >> drivers/dma/amba-pl08x.c | 14 +

Re: [PATCH] dmaengine: remove DBGFS_FUNC_DECL()

2018-11-30 Thread Sinan Kaya
On 11/30/2018 10:42 AM, Yangtao Li wrote: We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define such a macro,so remove DBGFS_FUNC_DECL.Also use macro to simplify some code. Signed-off-by: Yangtao Li --- drivers/dma/amba-pl08x.c | 14 ++ drivers/dma/mic_x100_dma.

[PATCH] dmaengine: remove DBGFS_FUNC_DECL()

2018-11-30 Thread Yangtao Li
We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define such a macro,so remove DBGFS_FUNC_DECL.Also use macro to simplify some code. Signed-off-by: Yangtao Li --- drivers/dma/amba-pl08x.c | 14 ++ drivers/dma/mic_x100_dma.c | 22 +++--- drivers/dma/