Re: [PATCH] dma-buf: system_heap: do not warn for costly allocation

2021-02-10 Thread Minchan Kim
On Wed, Feb 10, 2021 at 06:14:46PM -0800, John Stultz wrote: > On Wed, Feb 10, 2021 at 3:17 PM Minchan Kim wrote: > > > > On Wed, Feb 10, 2021 at 01:40:02PM -0800, John Stultz wrote: > > > On Wed, Feb 10, 2021 at 9:48 AM Minchan Kim wrote: > > > > > > > > On Wed, Feb 10, 2021 at 09:32:09AM -0800,

Re: [PATCH] dma-buf: system_heap: do not warn for costly allocation

2021-02-10 Thread John Stultz
On Wed, Feb 10, 2021 at 3:17 PM Minchan Kim wrote: > > On Wed, Feb 10, 2021 at 01:40:02PM -0800, John Stultz wrote: > > On Wed, Feb 10, 2021 at 9:48 AM Minchan Kim wrote: > > > > > > On Wed, Feb 10, 2021 at 09:32:09AM -0800, John Stultz wrote: > > > > On Wed, Feb 10, 2021 at 8:26 AM Minchan Kim

Re: [PATCH] dma-buf: system_heap: do not warn for costly allocation

2021-02-10 Thread Minchan Kim
On Wed, Feb 10, 2021 at 01:40:02PM -0800, John Stultz wrote: > On Wed, Feb 10, 2021 at 9:48 AM Minchan Kim wrote: > > > > On Wed, Feb 10, 2021 at 09:32:09AM -0800, John Stultz wrote: > > > On Wed, Feb 10, 2021 at 8:26 AM Minchan Kim wrote: > > > > > > > > Linux VM is not hard to support PAGE_ALLO

Re: [PATCH] dma-buf: system_heap: do not warn for costly allocation

2021-02-10 Thread John Stultz
On Wed, Feb 10, 2021 at 9:48 AM Minchan Kim wrote: > > On Wed, Feb 10, 2021 at 09:32:09AM -0800, John Stultz wrote: > > On Wed, Feb 10, 2021 at 8:26 AM Minchan Kim wrote: > > > > > > Linux VM is not hard to support PAGE_ALLOC_COSTLY_ODER allocation > > > so normally expects driver passes __GFP_NO

Re: [PATCH] dma-buf: system_heap: do not warn for costly allocation

2021-02-10 Thread kernel test robot
Hi Minchan, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.11-rc7 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented i

Re: [PATCH] dma-buf: system_heap: do not warn for costly allocation

2021-02-10 Thread Minchan Kim
On Wed, Feb 10, 2021 at 09:32:09AM -0800, John Stultz wrote: > On Wed, Feb 10, 2021 at 8:26 AM Minchan Kim wrote: > > > > Linux VM is not hard to support PAGE_ALLOC_COSTLY_ODER allocation > > so normally expects driver passes __GFP_NOWARN in that case > > if they has fallback options. > > > > syst

Re: [PATCH] dma-buf: system_heap: do not warn for costly allocation

2021-02-10 Thread Minchan Kim
On Wed, Feb 10, 2021 at 09:24:52AM -0800, Suren Baghdasaryan wrote: > The code looks fine to me. Description needs a bit polishing :) > > On Wed, Feb 10, 2021 at 8:26 AM Minchan Kim wrote: > > > > Linux VM is not hard to support PAGE_ALLOC_COSTLY_ODER allocation > > so normally expects driver pas

Re: [PATCH] dma-buf: system_heap: do not warn for costly allocation

2021-02-10 Thread John Stultz
On Wed, Feb 10, 2021 at 8:26 AM Minchan Kim wrote: > > Linux VM is not hard to support PAGE_ALLOC_COSTLY_ODER allocation > so normally expects driver passes __GFP_NOWARN in that case > if they has fallback options. > > system_heap in dmabuf is the case so do not flood into demsg > with the warning

Re: [PATCH] dma-buf: system_heap: do not warn for costly allocation

2021-02-10 Thread Suren Baghdasaryan
The code looks fine to me. Description needs a bit polishing :) On Wed, Feb 10, 2021 at 8:26 AM Minchan Kim wrote: > > Linux VM is not hard to support PAGE_ALLOC_COSTLY_ODER allocation > so normally expects driver passes __GFP_NOWARN in that case > if they has fallback options. > > system_heap in

[PATCH] dma-buf: system_heap: do not warn for costly allocation

2021-02-10 Thread Minchan Kim
Linux VM is not hard to support PAGE_ALLOC_COSTLY_ODER allocation so normally expects driver passes __GFP_NOWARN in that case if they has fallback options. system_heap in dmabuf is the case so do not flood into demsg with the warning for recording more precious information logs. (below is ION warn