Re: [PATCH] dma: Revert "dmaengine: mic_x100: add missing spin_unlock"

2016-01-06 Thread Vinod Koul
On Mon, Jan 04, 2016 at 05:40:39PM -0500, Ashutosh Dixit wrote: > On Sun, Jan 03 2016 at 10:35:26 PM, "Koul, Vinod" > wrote: > > On Tue, Dec 22, 2015 at 07:35:23PM -0800, Ashutosh Dixit wrote: > >> This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing > >> spin_unlock"). > >> > >> T

Re: [PATCH] dma: Revert "dmaengine: mic_x100: add missing spin_unlock"

2016-01-04 Thread Ashutosh Dixit
On Sun, Jan 03 2016 at 10:35:26 PM, "Koul, Vinod" wrote: > On Tue, Dec 22, 2015 at 07:35:23PM -0800, Ashutosh Dixit wrote: >> This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing >> spin_unlock"). >> >> The above patch is incorrect. There is nothing wrong with the original >> code.

Re: [PATCH] dma: Revert "dmaengine: mic_x100: add missing spin_unlock"

2016-01-04 Thread Vinod Koul
On Mon, Jan 04, 2016 at 03:35:34PM +0100, Lars-Peter Clausen wrote: > On 01/04/2016 04:35 AM, Vinod Koul wrote: > > On Tue, Dec 22, 2015 at 07:35:23PM -0800, Ashutosh Dixit wrote: > >> This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing > >> spin_unlock"). > >> > >> The above patch

Re: [PATCH] dma: Revert "dmaengine: mic_x100: add missing spin_unlock"

2016-01-04 Thread Lars-Peter Clausen
On 01/04/2016 04:35 AM, Vinod Koul wrote: > On Tue, Dec 22, 2015 at 07:35:23PM -0800, Ashutosh Dixit wrote: >> This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing >> spin_unlock"). >> >> The above patch is incorrect. There is nothing wrong with the original >> code. The spin_lock is

Re: [PATCH] dma: Revert "dmaengine: mic_x100: add missing spin_unlock"

2016-01-03 Thread Vinod Koul
On Tue, Dec 22, 2015 at 07:35:23PM -0800, Ashutosh Dixit wrote: > This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing > spin_unlock"). > > The above patch is incorrect. There is nothing wrong with the original > code. The spin_lock is acquired in the "prep" functions and released >

Re: [PATCH] dma: Revert "dmaengine: mic_x100: add missing spin_unlock"

2015-12-22 Thread Ashutosh Dixit
On Wed, Dec 23 2015 at 12:45:31 AM, Saurabh Sengar wrote: > On 23 December 2015 at 09:05, Ashutosh Dixit wrote: >> This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing >> spin_unlock"). >> >> The above patch is incorrect. There is nothing wrong with the original >> code. The spin_

Re: [PATCH] dma: Revert "dmaengine: mic_x100: add missing spin_unlock"

2015-12-22 Thread Saurabh Sengar
On 23 December 2015 at 09:05, Ashutosh Dixit wrote: > This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing > spin_unlock"). > > The above patch is incorrect. There is nothing wrong with the original > code. The spin_lock is acquired in the "prep" functions and released > in "submit"

[PATCH] dma: Revert "dmaengine: mic_x100: add missing spin_unlock"

2015-12-22 Thread Ashutosh Dixit
This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing spin_unlock"). The above patch is incorrect. There is nothing wrong with the original code. The spin_lock is acquired in the "prep" functions and released in "submit". Signed-off-by: Ashutosh Dixit --- drivers/dma/mic_x100_dma.