Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-04 Thread Pranith Kumar
On Mon, Aug 4, 2014 at 6:48 AM, Joe Thornber wrote: > On Sun, Aug 03, 2014 at 12:01:17AM -0400, Pranith Kumar wrote: >> Also dm_cblock_t is uint32_t, but atomic_t changes that to int. You >> should correct that to atomic64_t to preserve original semantics. > > atomic_t used to have only 24 bits of

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-04 Thread Joe Thornber
On Sun, Aug 03, 2014 at 12:01:17AM -0400, Pranith Kumar wrote: > Also dm_cblock_t is uint32_t, but atomic_t changes that to int. You > should correct that to atomic64_t to preserve original semantics. atomic_t used to have only 24 bits of range due to the Sparc implementation holding a lock in one

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
On Sun, Aug 3, 2014 at 1:17 AM, Pranith Kumar wrote: > On 08/03/2014 12:57 AM, Pranith Kumar wrote: >> On 08/03/2014 12:46 AM, Pranith Kumar wrote: >>> On 08/02/2014 10:10 PM, Pranith Kumar wrote: Corrently adding Anssi this time. On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar >>>

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
On 08/03/2014 12:57 AM, Pranith Kumar wrote: > On 08/03/2014 12:46 AM, Pranith Kumar wrote: >> On 08/02/2014 10:10 PM, Pranith Kumar wrote: >>> Corrently adding Anssi this time. >>> >>> On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar >>> wrote: Hello Anssi, Joe, Mike, I just found y

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
On 08/03/2014 12:46 AM, Pranith Kumar wrote: > On 08/02/2014 10:10 PM, Pranith Kumar wrote: >> Corrently adding Anssi this time. >> >> On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar wrote: >>> Hello Anssi, Joe, Mike, >>> >>> I just found your patch in the latest rc and wanted to ask a few >>> ques

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
On 08/02/2014 10:10 PM, Pranith Kumar wrote: > Corrently adding Anssi this time. > > On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar wrote: >> Hello Anssi, Joe, Mike, >> >> I just found your patch in the latest rc and wanted to ask a few >> questions. I am not sure how this patch helps at all othe

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
On Sat, Aug 2, 2014 at 11:33 PM, Anssi Hannula wrote: > 03.08.2014, 05:10, Pranith Kumar kirjoitti: >> Corrently adding Anssi this time. >> >> On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar wrote: >>> Hello Anssi, Joe, Mike, > > Hi, > >>> I just found your patch in the latest rc and wanted to ask

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Anssi Hannula
03.08.2014, 05:10, Pranith Kumar kirjoitti: > Corrently adding Anssi this time. > > On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar wrote: >> Hello Anssi, Joe, Mike, Hi, >> I just found your patch in the latest rc and wanted to ask a few >> questions. I am not sure how this patch helps at all ot

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
Corrently adding Anssi this time. On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar wrote: > Hello Anssi, Joe, Mike, > > I just found your patch in the latest rc and wanted to ask a few > questions. I am not sure how this patch helps at all other than luck in > that dm_cblock_t type is of type int32

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
Correctly adding Anssi this time. On Sat, Aug 2, 2014 at 10:00 PM, Pranith Kumar wrote: > Hello Anssi, Joe, Mike, > > I just found your patch in the latest rc and wanted to ask a few > questions. I am not sure how this patch helps at all other than luck in > that dm_cblock_t type is of type int32

Re: [PATCH] dm cache: fix race affecting dirty block count

2014-08-02 Thread Pranith Kumar
Hello Anssi, Joe, Mike, I just found your patch in the latest rc and wanted to ask a few questions. I am not sure how this patch helps at all other than luck in that dm_cblock_t type is of type int32_t, which should guarantee that it is atomic on most platforms. Which begs the question, what platf