Re: [dm-devel] [PATCH] dm-io: Prevent the danging point of the sync io callback function

2014-06-30 Thread Joe Thornber
On Fri, Jun 27, 2014 at 02:44:41PM -0400, Mikulas Patocka wrote: > I suggest - split it to two patches, a minimal patch that fixes the bug by > changing sleeper to completion and the second patch with remaining changes > - so that only the first patch can be backported to stable kernels. Agreed.

Re: [dm-devel] [PATCH] dm-io: Prevent the danging point of the sync io callback function

2014-06-27 Thread Mikulas Patocka
On Fri, 27 Jun 2014, Mikulas Patocka wrote: > > > On Fri, 27 Jun 2014, Minfei Huang wrote: > > > BUG: unable to handle kernel NULL pointer dereference at 0046 > > IP: [] dec_count+0x5f/0x80 [dm_mod] > > PGD 0 > > Oops: [#1] SMP > > last sysfs file: > > /sys/devices/pci:0

Re: [dm-devel] [PATCH] dm-io: Prevent the danging point of the sync io callback function

2014-06-27 Thread Mikulas Patocka
On Fri, 27 Jun 2014, Joe Thornber wrote: > On Fri, Jun 27, 2014 at 12:01:30PM +0800, Minfei Huang wrote: > > The io address in callback function will become the danging point, > > cause by the thread of sync io wakes up by other threads > > and return to relieve the io address, > > Yes, well fo

Re: [dm-devel] [PATCH] dm-io: Prevent the danging point of the sync io callback function

2014-06-27 Thread Mikulas Patocka
On Fri, 27 Jun 2014, Minfei Huang wrote: > BUG: unable to handle kernel NULL pointer dereference at 0046 > IP: [] dec_count+0x5f/0x80 [dm_mod] > PGD 0 > Oops: [#1] SMP > last sysfs file: > /sys/devices/pci:00/:00:02.2/:02:00.0/host0/scsi_host/host0/proc_name > > Pi

Re: [dm-devel] [PATCH] dm-io: Prevent the danging point of the sync io callback function

2014-06-27 Thread Joe Thornber
On Fri, Jun 27, 2014 at 12:01:30PM +0800, Minfei Huang wrote: > The io address in callback function will become the danging point, > cause by the thread of sync io wakes up by other threads > and return to relieve the io address, Yes, well found. I prefer the following fix however. - Joe Auth

[PATCH] dm-io: Prevent the danging point of the sync io callback function

2014-06-26 Thread Minfei Huang
BUG: unable to handle kernel NULL pointer dereference at 0046 IP: [] dec_count+0x5f/0x80 [dm_mod] PGD 0 Oops: [#1] SMP last sysfs file: /sys/devices/pci:00/:00:02.2/:02:00.0/host0/scsi_host/host0/proc_name Pid: 2708, comm: kcopyd Tainted: GW --- H