Re: [PATCH] direct-io: squelch maybe-uninitialized warning in do_direct_IO()

2014-07-01 Thread Paul Bolle
On Mon, 2014-06-23 at 12:54 -0700, Markus Mayer wrote: > I did a bit of digging on this and I am wondering if the initialization > of "to" and "from" to 0 should instead be done in dio_get_page(). > > The warning is caused by the return in dio_get_page(): > > ret = dio_refill_pages(

Re: [PATCH] direct-io: squelch maybe-uninitialized warning in do_direct_IO()

2014-06-23 Thread Markus Mayer
I did a bit of digging on this and I am wondering if the initialization of "to" and "from" to 0 should instead be done in dio_get_page(). The warning is caused by the return in dio_get_page(): ret = dio_refill_pages(dio, sdio); if (ret) retu

[PATCH] direct-io: squelch maybe-uninitialized warning in do_direct_IO()

2014-06-20 Thread Jason Cooper
The following warnings: fs/direct-io.c: In function ‘__blockdev_direct_IO’: fs/direct-io.c:1011:12: warning: ‘to’ may be used uninitialized in this function [-Wmaybe-uninitialized] fs/direct-io.c:913:16: note: ‘to’ was declared here fs/direct-io.c:1011:12: warning: ‘from’ may be used unin