Re: [PATCH] direct-io: Minor cleanups in do_blockdev_direct_IO

2018-03-03 Thread Nikolay Borisov
On 3.03.2018 02:24, Andrew Morton wrote: > On Mon, 26 Feb 2018 11:54:30 +0200 Nikolay Borisov wrote: > >> We already get the block counts and the calculate the end block at the >> beginning of the function. Let's use the local variables for consistency and >> readability. No functional changes

Re: [PATCH] direct-io: Minor cleanups in do_blockdev_direct_IO

2018-03-02 Thread Andrew Morton
On Mon, 26 Feb 2018 11:54:30 +0200 Nikolay Borisov wrote: > We already get the block counts and the calculate the end block at the > beginning of the function. Let's use the local variables for consistency and > readability. No functional changes > Fair enough. > --- a/fs/direct-io.c > +++ b/f

[PATCH] direct-io: Minor cleanups in do_blockdev_direct_IO

2018-02-26 Thread Nikolay Borisov
We already get the block counts and the calculate the end block at the beginning of the function. Let's use the local variables for consistency and readability. No functional changes Signed-off-by: Nikolay Borisov Reviewed-by: Jeff Moyer --- Andrew, Sending to you since this has been languishi

Re: [PATCH] direct-io: Minor cleanups in do_blockdev_direct_IO

2018-02-21 Thread Nikolay Borisov
On 2.08.2017 10:10, Nikolay Borisov wrote: > We already get the block counts and the calculate the end block at the > beginning of the function. Let's use the local variables for consistency and > readability. No functional changes > > Signed-off-by: Nikolay Borisov > --- > fs/direct-io.c | 5

Re: [PATCH] direct-io: Minor cleanups in do_blockdev_direct_IO

2017-09-15 Thread Nikolay Borisov
On 2.08.2017 10:10, Nikolay Borisov wrote: > We already get the block counts and the calculate the end block at the > beginning of the function. Let's use the local variables for consistency and > readability. No functional changes > > Signed-off-by: Nikolay Borisov > --- ping > fs/direct-i

Re: [PATCH] direct-io: Minor cleanups in do_blockdev_direct_IO

2017-08-03 Thread Jeff Moyer
Nikolay Borisov writes: > We already get the block counts and the calculate the end block at the > beginning of the function. Let's use the local variables for consistency and > readability. No functional changes > > Signed-off-by: Nikolay Borisov Looks ok to me. Reviewed-by: Jeff Moyer

[PATCH] direct-io: Minor cleanups in do_blockdev_direct_IO

2017-08-02 Thread Nikolay Borisov
We already get the block counts and the calculate the end block at the beginning of the function. Let's use the local variables for consistency and readability. No functional changes Signed-off-by: Nikolay Borisov --- fs/direct-io.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) dif