Re: [PATCH] device_cgroup: fix unchecked cgroup parent usage

2012-11-01 Thread Aristeu Rozanski
On Wed, Oct 31, 2012 at 04:35:01PM -0700, Andrew Morton wrote: > On Wed, 31 Oct 2012 12:04:30 -0400 > Aristeu Rozanski wrote: > > > In 4cef7299b4786879a3e113e84084a72b24590c5b the cgroup parent usage is > > unchecked. root will not have a parent and trying to use > > device.{allow,deny} will caus

Re: [PATCH] device_cgroup: fix unchecked cgroup parent usage

2012-10-31 Thread Andrew Morton
On Wed, 31 Oct 2012 12:04:30 -0400 Aristeu Rozanski wrote: > In 4cef7299b4786879a3e113e84084a72b24590c5b the cgroup parent usage is > unchecked. root will not have a parent and trying to use > device.{allow,deny} will cause problems. >From my reading of the code "problems" means "kernel null poi

Re: [PATCH] device_cgroup: fix unchecked cgroup parent usage

2012-10-31 Thread Serge Hallyn
Quoting Aristeu Rozanski (a...@redhat.com): > In 4cef7299b4786879a3e113e84084a72b24590c5b the cgroup parent usage is > unchecked. root will not have a parent and trying to use > device.{allow,deny} will cause problems. For some reason my stressing > scripts didn't test the root directory so I didn'

Re: [PATCH] device_cgroup: fix unchecked cgroup parent usage

2012-10-31 Thread Tejun Heo
On Wed, Oct 31, 2012 at 12:04:30PM -0400, Aristeu Rozanski wrote: > In 4cef7299b4786879a3e113e84084a72b24590c5b the cgroup parent usage is > unchecked. root will not have a parent and trying to use > device.{allow,deny} will cause problems. For some reason my stressing > scripts didn't test the roo

[PATCH] device_cgroup: fix unchecked cgroup parent usage

2012-10-31 Thread Aristeu Rozanski
In 4cef7299b4786879a3e113e84084a72b24590c5b the cgroup parent usage is unchecked. root will not have a parent and trying to use device.{allow,deny} will cause problems. For some reason my stressing scripts didn't test the root directory so I didn't catch it on my regular tests. Andrew, Tejun, this