Re: [PATCH] csky: Fix a size determination in gpr_get()

2020-12-23 Thread Zhenzhong Duan
On Wed, Dec 23, 2020 at 10:57 PM Guo Ren wrote: > > Hi Zhengzhong, > > I'll take it, thx. Thanks Guo. Zhenzhong

Re: [PATCH] csky: Fix a size determination in gpr_get()

2020-12-23 Thread Guo Ren
Hi Zhengzhong, I'll take it, thx. On Wed, Dec 23, 2020 at 10:31 AM Zhenzhong Duan wrote: > > On Wed, Sep 23, 2020 at 12:52 PM Al Viro wrote: > > > > On Wed, Sep 23, 2020 at 10:37:31AM +0800, Guo Ren wrote: > > > > > > What's going on there? The mapping is really weird - assuming > > > > you ha

Re: [PATCH] csky: Fix a size determination in gpr_get()

2020-12-22 Thread Zhenzhong Duan
On Wed, Sep 23, 2020 at 12:52 PM Al Viro wrote: > > On Wed, Sep 23, 2020 at 10:37:31AM +0800, Guo Ren wrote: > > > > What's going on there? The mapping is really weird - assuming > > > you had v0..v31 in the first 32 elements of regs->vr[], you > > > end up with > > > > > > v0 v1 v2 v3 v2 v3 v6 v

Re: [PATCH] csky: Fix a size determination in gpr_get()

2020-09-24 Thread Guo Ren
On Wed, Sep 23, 2020 at 12:52 PM Al Viro wrote: > > On Wed, Sep 23, 2020 at 10:37:31AM +0800, Guo Ren wrote: > > > > What's going on there? The mapping is really weird - assuming > > > you had v0..v31 in the first 32 elements of regs->vr[], you > > > end up with > > > > > > v0 v1 v2 v3 v2 v3 v6 v

Re: [PATCH] csky: Fix a size determination in gpr_get()

2020-09-22 Thread Al Viro
On Wed, Sep 23, 2020 at 10:37:31AM +0800, Guo Ren wrote: > > What's going on there? The mapping is really weird - assuming > > you had v0..v31 in the first 32 elements of regs->vr[], you > > end up with > > > > v0 v1 v2 v3 v2 v3 v6 v7 v4 v5 v10 v11 v6 v7 v14 v15 > > v8 v9 v18 v19 v10 v11 v22 v23

Re: [PATCH] csky: Fix a size determination in gpr_get()

2020-09-22 Thread Guo Ren
On Wed, Sep 23, 2020 at 8:23 AM Al Viro wrote: > > On Wed, Sep 23, 2020 at 08:03:20AM +0800, Guo Ren wrote: > > Thx Duan, > > > > Acked-by: Guo Ren > > > > Hi AI, > > > > I found the broken commit still has a question: > > > > > commit dcad7854fcce6a2d49b6a3ead5bbefeff047e559 > > > Author: Al Vir

Re: [PATCH] csky: Fix a size determination in gpr_get()

2020-09-22 Thread Zhenzhong Duan
On Wed, Sep 23, 2020 at 12:29 AM Al Viro wrote: > > On Tue, Sep 22, 2020 at 05:15:05PM +0800, Zhenzhong Duan wrote: > > "*" is missed in size determination as we are passing register set > > rather than a pointer. > > Ack. I can push it to Linus today, unless you want it to go through > csky tre

Re: [PATCH] csky: Fix a size determination in gpr_get()

2020-09-22 Thread Al Viro
On Wed, Sep 23, 2020 at 08:03:20AM +0800, Guo Ren wrote: > Thx Duan, > > Acked-by: Guo Ren > > Hi AI, > > I found the broken commit still has a question: > > > commit dcad7854fcce6a2d49b6a3ead5bbefeff047e559 > > Author: Al Viro > > Date: Tue Jun 16 15:28:29 2020 -0400 > > >csky: switch

Re: [PATCH] csky: Fix a size determination in gpr_get()

2020-09-22 Thread Guo Ren
Thx Duan, Acked-by: Guo Ren Hi AI, I found the broken commit still has a question: > commit dcad7854fcce6a2d49b6a3ead5bbefeff047e559 > Author: Al Viro > Date: Tue Jun 16 15:28:29 2020 -0400 >csky: switch to ->regset_get() >NB: WTF "- what the fuck :(" is fpregs_get() playing at???

Re: [PATCH] csky: Fix a size determination in gpr_get()

2020-09-22 Thread Al Viro
On Tue, Sep 22, 2020 at 05:15:05PM +0800, Zhenzhong Duan wrote: > "*" is missed in size determination as we are passing register set > rather than a pointer. Ack. I can push it to Linus today, unless you want it to go through csky tree. Preferences? > Fixes: dcad7854fcce ("sky: switch to ->reg

[PATCH] csky: Fix a size determination in gpr_get()

2020-09-22 Thread Zhenzhong Duan
"*" is missed in size determination as we are passing register set rather than a pointer. Fixes: dcad7854fcce ("sky: switch to ->regset_get()") Signed-off-by: Zhenzhong Duan --- arch/csky/kernel/ptrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/csky/kernel/ptrace