Re: [PATCH] crypto: squash lines for simple wrapper functions

2016-09-13 Thread Joe Perches
On Wed, 2016-09-14 at 11:10 +0900, Masahiro Yamada wrote: > 2016-09-13 4:44 GMT+09:00 Joe Perches : > > On Tue, 2016-09-13 at 04:27 +0900, Masahiro Yamada wrote: > > > Remove unneeded variables and assignments. > > Was this found by visual inspection or some tool? > > If it's via a tool, it's good

Re: [PATCH] crypto: squash lines for simple wrapper functions

2016-09-13 Thread Masahiro Yamada
Hi Joe, 2016-09-13 4:44 GMT+09:00 Joe Perches : > On Tue, 2016-09-13 at 04:27 +0900, Masahiro Yamada wrote: >> Remove unneeded variables and assignments. > > Was this found by visual inspection or some tool? > > If it's via a tool, it's good to mention that in the changelog. I used Coccinelle, b

Re: [PATCH] crypto: squash lines for simple wrapper functions

2016-09-13 Thread Herbert Xu
On Tue, Sep 13, 2016 at 04:27:54AM +0900, Masahiro Yamada wrote: > Remove unneeded variables and assignments. > > Signed-off-by: Masahiro Yamada Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: squash lines for simple wrapper functions

2016-09-12 Thread Joe Perches
On Tue, 2016-09-13 at 04:27 +0900, Masahiro Yamada wrote: > Remove unneeded variables and assignments. Was this found by visual inspection or some tool? If it's via a tool, it's good to mention that in the changelog.

[PATCH] crypto: squash lines for simple wrapper functions

2016-09-12 Thread Masahiro Yamada
Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada --- crypto/crct10dif_generic.c | 5 + crypto/mcryptd.c | 7 +-- drivers/crypto/hifn_795x.c | 12 ++-- 3 files changed, 4 insertions(+), 20 deletions(-) diff --git a/crypto/crct10dif_generic.c