Re: [PATCH] crypto: fix FTBFS with ARM SHA1-asm and THUMB2_KERNEL

2013-01-22 Thread Matt Sealey
On Tue, Jan 22, 2013 at 1:50 AM, Jussi Kivilinna wrote: > >> There is 'tcrypt' module in crypto/ for quick benchmarking. 'modprobe >> tcrypt mode=500 sec=1' tests AES in various cipher-modes, using different >> buffer sizes and outputs results to kernel log. >> > > Actually mode=200 might be bette

Re: [PATCH] crypto: fix FTBFS with ARM SHA1-asm and THUMB2_KERNEL

2013-01-21 Thread Jussi Kivilinna
Quoting Jussi Kivilinna : Quoting Matt Sealey : This question is to the implementor/committer (Dave McCullough), how exactly did you measure the benchmark and can we reproduce it on some other ARM box? If it's long and laborious and not so important to test the IPsec tunnel use-case, what wou

Re: [PATCH] crypto: fix FTBFS with ARM SHA1-asm and THUMB2_KERNEL

2013-01-21 Thread Jussi Kivilinna
Quoting Matt Sealey : This question is to the implementor/committer (Dave McCullough), how exactly did you measure the benchmark and can we reproduce it on some other ARM box? If it's long and laborious and not so important to test the IPsec tunnel use-case, what would be the simplest possible

Re: [PATCH] crypto: fix FTBFS with ARM SHA1-asm and THUMB2_KERNEL

2013-01-21 Thread Matt Sealey
On Mon, Jan 21, 2013 at 4:46 PM, Nicolas Pitre wrote: > On Mon, 21 Jan 2013, Matt Sealey wrote: > >> The optimized assembler SHA1 code for ARM does not conform to Thumb2 >> register usage requirements, so it cannot be built when the kernel is >> configured with THUMB2_KERNEL. >> >> Fix the FTBFS f

Re: [PATCH] crypto: fix FTBFS with ARM SHA1-asm and THUMB2_KERNEL

2013-01-21 Thread Nicolas Pitre
On Mon, 21 Jan 2013, Matt Sealey wrote: > The optimized assembler SHA1 code for ARM does not conform to Thumb2 > register usage requirements, so it cannot be built when the kernel is > configured with THUMB2_KERNEL. > > Fix the FTBFS for now by preventing misconfigurations of the kernel. > > Sig

[PATCH] crypto: fix FTBFS with ARM SHA1-asm and THUMB2_KERNEL

2013-01-21 Thread Matt Sealey
The optimized assembler SHA1 code for ARM does not conform to Thumb2 register usage requirements, so it cannot be built when the kernel is configured with THUMB2_KERNEL. Fix the FTBFS for now by preventing misconfigurations of the kernel. Signed-off-by: Matt Sealey --- crypto/Kconfig |2 +-