Re: [PATCH] crypto: ecrdsa - use subsys_initcall instead of module_init

2020-12-01 Thread Ard Biesheuvel
On Mon, 30 Nov 2020 at 07:58, Tianjia Zhang wrote: > > > > On 11/30/20 10:24 AM, Herbert Xu wrote: > > On Mon, Nov 30, 2020 at 10:21:56AM +0800, Tianjia Zhang wrote: > >> > >>> That is true only if there are non-generic implementations of > >>> the algorithms, which is not the case here. Please e

Re: [PATCH] crypto: ecrdsa - use subsys_initcall instead of module_init

2020-11-29 Thread Tianjia Zhang
On 11/30/20 10:24 AM, Herbert Xu wrote: On Mon, Nov 30, 2020 at 10:21:56AM +0800, Tianjia Zhang wrote: That is true only if there are non-generic implementations of the algorithms, which is not the case here. Please explain the real reason why this is needed. This is a generic algorithm,

Re: [PATCH] crypto: ecrdsa - use subsys_initcall instead of module_init

2020-11-29 Thread Herbert Xu
On Mon, Nov 30, 2020 at 10:21:56AM +0800, Tianjia Zhang wrote: > > > That is true only if there are non-generic implementations of > > the algorithms, which is not the case here. Please explain the > > real reason why this is needed. > > This is a generic algorithm, the author Vitaly Chikunov has

Re: [PATCH] crypto: ecrdsa - use subsys_initcall instead of module_init

2020-11-29 Thread Tianjia Zhang
Hi Herbert, On 10/15/20 8:05 PM, Herbert Xu wrote: On Thu, Oct 15, 2020 at 07:02:41PM +0800, Tianjia Zhang wrote: All templates and generic algorithms have been registered in subsys_initcall instead of module_init. The ecrdsa algorithm happened to be missed. Here is a fix for it. That is true

Re: [PATCH] crypto: ecrdsa - use subsys_initcall instead of module_init

2020-10-15 Thread Herbert Xu
On Thu, Oct 15, 2020 at 07:02:41PM +0800, Tianjia Zhang wrote: > All templates and generic algorithms have been registered in > subsys_initcall instead of module_init. The ecrdsa algorithm > happened to be missed. Here is a fix for it. That is true only if there are non-generic implementations of

[PATCH] crypto: ecrdsa - use subsys_initcall instead of module_init

2020-10-15 Thread Tianjia Zhang
All templates and generic algorithms have been registered in subsys_initcall instead of module_init. The ecrdsa algorithm happened to be missed. Here is a fix for it. Cc: Vitaly Chikunov Signed-off-by: Tianjia Zhang --- crypto/ecrdsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff