Re: [PATCH] crypto: Use padlock.ko only as a module

2007-04-29 Thread Ingo Oeser
Hi Scott, On Sunday 29 April 2007, Simon Arlott wrote: > Ideally I'd just remove that module completely, all it does is > trigger the loading of the other two modules when modules are > used - so I'll submit a patch for that instead. That's much better! When you force a feature to be a module

Re: [PATCH] crypto: Use padlock.ko only as a module

2007-04-28 Thread Simon Arlott
On 28/04/07 23:37, Randy Dunlap wrote: On Sat, 28 Apr 2007 17:44:42 +0100 Simon Arlott wrote: The padlock.ko module is completely useless when compiled in because it can't do anything and gets run too early to output anything useful. --- a/drivers/crypto/Makefile +++ b/drivers/crypto/Makefile

Re: [PATCH] crypto: Use padlock.ko only as a module

2007-04-28 Thread Randy Dunlap
On Sat, 28 Apr 2007 17:44:42 +0100 Simon Arlott wrote: > The padlock.ko module is completely useless when compiled in > because it can't do anything and gets run too early to output > anything useful: > > [6.052000] padlock: No VIA PadLock drivers have been loaded. > [6.052000] padlock:

[PATCH] crypto: Use padlock.ko only as a module

2007-04-28 Thread Simon Arlott
The padlock.ko module is completely useless when compiled in because it can't do anything and gets run too early to output anything useful: [6.052000] padlock: No VIA PadLock drivers have been loaded. [6.052000] padlock: Using VIA PadLock ACE for AES algorithm. [6.052000] padlock: U