Re: [PATCH] cpuidle: Fix Coding style reported by checkpatch.pl

2014-07-14 Thread pramod gurav
On Mon, Jul 14, 2014 at 11:38 PM, Rafael J. Wysocki wrote: > On Monday, July 14, 2014 12:40:24 PM pramod gurav wrote: >> Hi Rafael, >> >> Can we consider these changes if there are no issues with this? > > Well, are you "fixing" checkpatch.pl warnings just for the sake of > this or is there a dee

Re: [PATCH] cpuidle: Fix Coding style reported by checkpatch.pl

2014-07-14 Thread Rafael J. Wysocki
On Monday, July 14, 2014 12:40:24 PM pramod gurav wrote: > Hi Rafael, > > Can we consider these changes if there are no issues with this? Well, are you "fixing" checkpatch.pl warnings just for the sake of this or is there a deeper reason? Rafael > On Fri, Jun 20, 2014 at 4:28 PM, pramod gurav

Re: [PATCH] cpuidle: Fix Coding style reported by checkpatch.pl

2014-07-14 Thread pramod gurav
Hi Rafael, Can we consider these changes if there are no issues with this? On Fri, Jun 20, 2014 at 4:28 PM, pramod gurav wrote: > +linux-pm > > On Fri, Jun 20, 2014 at 4:27 PM, Pramod Gurav > wrote: >> Fixed: ERROR: do not use assignment in if condition >> Fixed: WARNING: EXPORT_SYMBOL should

Re: [PATCH] cpuidle: Fix Coding style reported by checkpatch.pl

2014-06-20 Thread pramod gurav
+linux-pm On Fri, Jun 20, 2014 at 4:27 PM, Pramod Gurav wrote: > Fixed: ERROR: do not use assignment in if condition > Fixed: WARNING: EXPORT_SYMBOL should immediately follow its function > Fixed: WARNING: line over 80 characters in a comment > > CC: Rafael J. Wysocki > CC: Daniel Lezcano > > S

[PATCH] cpuidle: Fix Coding style reported by checkpatch.pl

2014-06-20 Thread Pramod Gurav
Fixed: ERROR: do not use assignment in if condition Fixed: WARNING: EXPORT_SYMBOL should immediately follow its function Fixed: WARNING: line over 80 characters in a comment CC: Rafael J. Wysocki CC: Daniel Lezcano Signed-off-by: Pramod Gurav --- drivers/cpuidle/cpuidle.c | 18 -