Re: [PATCH] cpufreq: speedstep: remove unnecessary static in speedstep_detect_chipset()

2017-07-21 Thread Rafael J. Wysocki
On Tuesday, July 04, 2017 10:09:21 PM Gustavo A. R. Silva wrote: > Remove unnecessary static on local variable hostbridge. > Such variable is initialized before being used, > on every execution path throughout the function. > The static has no benefit and, removing it reduces > the code size. > >

Re: [PATCH] cpufreq: speedstep: remove unnecessary static in speedstep_detect_chipset()

2017-07-05 Thread Dominik Brodowski
Viresh, Gustavo, On Wed, Jul 05, 2017 at 09:23:44AM +0530, Viresh Kumar wrote: > + Dominic, > > On 04-07-17, 22:09, Gustavo A. R. Silva wrote: > > Remove unnecessary static on local variable hostbridge. > > Such variable is initialized before being used, > > on every execution path throughout the

[PATCH] cpufreq: speedstep: remove unnecessary static in speedstep_detect_chipset()

2017-07-04 Thread Gustavo A. R. Silva
Remove unnecessary static on local variable hostbridge. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the code size. This issue was detected using Coccinelle and the following semantic patch: @ba

Re: [PATCH] cpufreq: speedstep: remove unnecessary static in speedstep_detect_chipset()

2017-07-04 Thread Viresh Kumar
+ Dominic, On 04-07-17, 22:09, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variable hostbridge. > Such variable is initialized before being used, > on every execution path throughout the function. > The static has no benefit and, removing it reduces > the code size. > > This i