Re: [PATCH] cpufreq: schedutil: Update last_update from sugov_set_iowait_boost()

2017-07-18 Thread Rafael J. Wysocki
On Tuesday, July 18, 2017 12:35:52 PM Juri Lelli wrote: > On 18/07/17 16:55, Viresh Kumar wrote: > > On 18-07-17, 12:20, Juri Lelli wrote: > > > Hi Viresh, > > > > > > On 18/07/17 10:24, Viresh Kumar wrote: > > [...] > > > > > > > It actually belongs here, IMHO. We update other fields (util, ma

Re: [PATCH] cpufreq: schedutil: Update last_update from sugov_set_iowait_boost()

2017-07-18 Thread Juri Lelli
On 18/07/17 16:55, Viresh Kumar wrote: > On 18-07-17, 12:20, Juri Lelli wrote: > > Hi Viresh, > > > > On 18/07/17 10:24, Viresh Kumar wrote: [...] > > > > It actually belongs here, IMHO. We update other fields (util, max, > > flags) > > Yeah, because they have bigger roles and aren't specific

Re: [PATCH] cpufreq: schedutil: Update last_update from sugov_set_iowait_boost()

2017-07-18 Thread Viresh Kumar
On 18-07-17, 12:20, Juri Lelli wrote: > Hi Viresh, > > On 18/07/17 10:24, Viresh Kumar wrote: > > sg_cpu->last_update is always updated right after we call > > sugov_set_iowait_boost() and its better to update it from that routine > > itself. This makes it more readable. > > > > Signed-off-by: Vi

Re: [PATCH] cpufreq: schedutil: Update last_update from sugov_set_iowait_boost()

2017-07-18 Thread Juri Lelli
Hi Viresh, On 18/07/17 10:24, Viresh Kumar wrote: > sg_cpu->last_update is always updated right after we call > sugov_set_iowait_boost() and its better to update it from that routine > itself. This makes it more readable. > > Signed-off-by: Viresh Kumar > --- > kernel/sched/cpufreq_schedutil.c

[PATCH] cpufreq: schedutil: Update last_update from sugov_set_iowait_boost()

2017-07-17 Thread Viresh Kumar
sg_cpu->last_update is always updated right after we call sugov_set_iowait_boost() and its better to update it from that routine itself. This makes it more readable. Signed-off-by: Viresh Kumar --- kernel/sched/cpufreq_schedutil.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -