Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-08-06 Thread Rafael J. Wysocki
On Thursday, August 6, 2020 7:54:47 AM CEST Doug Smythies wrote: > On 2020.08.03 10:09 Rafael J. Wysocki wrote: > > On Sunday, August 2, 2020 5:17:39 PM CEST Doug Smythies wrote: > > > On 2020.07.19 04:43 Rafael J. Wysocki wrote: > > > > On Fri, Jul 17, 2020 at 3:37 PM Doug Smythies > > > > wrote

RE: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-08-05 Thread Doug Smythies
On 2020.08.03 10:09 Rafael J. Wysocki wrote: > On Sunday, August 2, 2020 5:17:39 PM CEST Doug Smythies wrote: > > On 2020.07.19 04:43 Rafael J. Wysocki wrote: > > > On Fri, Jul 17, 2020 at 3:37 PM Doug Smythies wrote: > > > > On 2020.07.16 05:08 Rafael J. Wysocki wrote: > > > > > On Wed, Jul 15, 2

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-08-03 Thread Rafael J. Wysocki
On Sunday, August 2, 2020 5:17:39 PM CEST Doug Smythies wrote: > Hi Rafael, > > On 2020.07.19 04:43 Rafael J. Wysocki wrote: > > On Fri, Jul 17, 2020 at 3:37 PM Doug Smythies wrote: > > > On 2020.07.16 05:08 Rafael J. Wysocki wrote: > > > > On Wed, Jul 15, 2020 at 10:39 PM Doug Smythies > > > >

RE: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-08-02 Thread Doug Smythies
Hi Rafael, On 2020.07.19 04:43 Rafael J. Wysocki wrote: > On Fri, Jul 17, 2020 at 3:37 PM Doug Smythies wrote: > > On 2020.07.16 05:08 Rafael J. Wysocki wrote: > > > On Wed, Jul 15, 2020 at 10:39 PM Doug Smythies > > > wrote: > > >> On 2020.07.14 11:16 Rafael J. Wysocki wrote: > > >> > > > >> >

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-31 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Thursday, July 30, 2020 2:49:34 AM CEST Francisco Jerez wrote: >> > > [cut] > >> >> > >> >> >> >> No, I explicitly dismissed that in my previous reply. >> >> >> > >> >> >> > But at the same time you seem to agree that without the non-CPU com= >> pon=3D >> >> ent

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-31 Thread Rafael J. Wysocki
On Thursday, July 30, 2020 2:49:34 AM CEST Francisco Jerez wrote: > [cut] > >> > > >> >> >> No, I explicitly dismissed that in my previous reply. > >> >> > > >> >> > But at the same time you seem to agree that without the non-CPU com= > pon=3D > >> ent > >> >> > (or thermal pressure) the existin

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-29 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Wednesday, July 29, 2020 7:46:08 AM CEST Francisco Jerez wrote: >> >> --==-=-= >> Content-Type: multipart/mixed; boundary="=-=-=" >> >> --=-=-= >> Content-Type: text/plain; charset=utf-8 >> Content-Disposition: inline >> Content-Transfer-Encoding: quoted-printab

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-29 Thread Rafael J. Wysocki
On Wednesday, July 29, 2020 7:46:08 AM CEST Francisco Jerez wrote: > > --==-=-= > Content-Type: multipart/mixed; boundary="=-=-=" > > --=-=-= > Content-Type: text/plain; charset=utf-8 > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > "Rafael J. Wysocki" writes: >

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-28 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Tuesday, July 28, 2020 4:32:22 AM CEST Francisco Jerez wrote: >> >> "Rafael J. Wysocki" writes: >> >> > On Tuesday, July 21, 2020 1:20:14 AM CEST Francisco Jerez wrote: >> > >> > [cut] >> > >> >> > >> >> > However, in the active mode the only updater of hwp_req_

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-28 Thread Rafael J. Wysocki
On Tuesday, July 28, 2020 4:32:22 AM CEST Francisco Jerez wrote: > > "Rafael J. Wysocki" writes: > > > On Tuesday, July 21, 2020 1:20:14 AM CEST Francisco Jerez wrote: > > > > [cut] > > > >> > > >> > However, in the active mode the only updater of hwp_req_cached is > >> > intel_pstate_hwp_set() a

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-28 Thread Rafael J. Wysocki
On Tuesday, July 21, 2020 1:20:14 AM CEST Francisco Jerez wrote: > [cut] > > If there is a bug, then what exactly is it, from the users' perspective? > > > > It can be reproduced easily as follows: > > | echo 1 > /sys/devices/system/cpu/intel_pstate/hwp_dynamic_boost > | for p in > /sys/devic

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-27 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Tuesday, July 21, 2020 1:20:14 AM CEST Francisco Jerez wrote: > > [cut] > >> > >> > However, in the active mode the only updater of hwp_req_cached is >> > intel_pstate_hwp_set() and this patch doesn't introduce any >> > differences in behavior in that case. >> > >

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-27 Thread Rafael J. Wysocki
On Wednesday, July 22, 2020 1:14:42 AM CEST Francisco Jerez wrote: > > --==-=-= > Content-Type: multipart/mixed; boundary="=-=-=" > > --=-=-= > Content-Type: text/plain; charset=utf-8 > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > Srinivas Pandruvada writes: >

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-27 Thread Rafael J. Wysocki
On Tuesday, July 21, 2020 1:20:14 AM CEST Francisco Jerez wrote: [cut] > > > > However, in the active mode the only updater of hwp_req_cached is > > intel_pstate_hwp_set() and this patch doesn't introduce any > > differences in behavior in that case. > > > > intel_pstate_hwp_set() is the only up

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-21 Thread Francisco Jerez
Srinivas Pandruvada writes: > On Mon, 2020-07-20 at 16:20 -0700, Francisco Jerez wrote: >> "Rafael J. Wysocki" writes: >> >> > On Fri, Jul 17, 2020 at 2:21 AM Francisco Jerez < >> > curroje...@riseup.net> wrote: >> > > "Rafael J. Wysocki" writes: >> > > > {...] > >> > Overall, so far, I'm see

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-21 Thread Srinivas Pandruvada
On Mon, 2020-07-20 at 16:20 -0700, Francisco Jerez wrote: > "Rafael J. Wysocki" writes: > > > On Fri, Jul 17, 2020 at 2:21 AM Francisco Jerez < > > curroje...@riseup.net> wrote: > > > "Rafael J. Wysocki" writes: > > > {...] > > Overall, so far, I'm seeing a claim that the CPU subsystem can be

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-20 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Fri, Jul 17, 2020 at 2:21 AM Francisco Jerez wrote: >> >> "Rafael J. Wysocki" writes: >> >> > On Wed, Jul 15, 2020 at 11:35 PM Francisco Jerez >> > wrote: >> >> >> >> "Rafael J. Wysocki" writes: >> >> >> >> > On Wed, Jul 15, 2020 at 2:09 AM Francisco Jerez

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-19 Thread Rafael J. Wysocki
On Fri, Jul 17, 2020 at 2:21 AM Francisco Jerez wrote: > > "Rafael J. Wysocki" writes: > > > On Wed, Jul 15, 2020 at 11:35 PM Francisco Jerez > > wrote: > >> > >> "Rafael J. Wysocki" writes: > >> > >> > On Wed, Jul 15, 2020 at 2:09 AM Francisco Jerez > >> > wrote: > >> >> > >> >> "Rafael J.

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-19 Thread Rafael J. Wysocki
Hi Doug, On Fri, Jul 17, 2020 at 3:37 PM Doug Smythies wrote: > > Hi Rafael, > > Thank you for your reply. > > On 2020.07.16 05:08 Rafael J. Wysocki wrote: > > On Wed, Jul 15, 2020 at 10:39 PM Doug Smythies wrote: > >> On 2020.07.14 11:16 Rafael J. Wysocki wrote: > >> > > >> > From: Rafael J. Wy

RE: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-17 Thread Doug Smythies
Hi Rafael, Thank you for your reply. On 2020.07.16 05:08 Rafael J. Wysocki wrote: > On Wed, Jul 15, 2020 at 10:39 PM Doug Smythies wrote: >> On 2020.07.14 11:16 Rafael J. Wysocki wrote: >> > >> > From: Rafael J. Wysocki >> ... >> > Since the passive mode hasn't worked with HWP at all, and it is

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-16 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Wed, Jul 15, 2020 at 11:35 PM Francisco Jerez > wrote: >> >> "Rafael J. Wysocki" writes: >> >> > On Wed, Jul 15, 2020 at 2:09 AM Francisco Jerez >> > wrote: >> >> >> >> "Rafael J. Wysocki" writes: >> >> >> >> > From: Rafael J. Wysocki >> >> > >> >> > Allow

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-16 Thread Rafael J. Wysocki
On Thu, Jul 16, 2020 at 3:14 AM Srinivas Pandruvada wrote: > > On Wed, 2020-07-15 at 14:35 -0700, Francisco Jerez wrote: > > "Rafael J. Wysocki" writes: > > > > > On Wed, Jul 15, 2020 at 2:09 AM Francisco Jerez < > > > curroje...@riseup.net> wrote: > > > > "Rafael J. Wysocki" writes: > > > > > >

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-16 Thread Rafael J. Wysocki
On Wed, Jul 15, 2020 at 11:35 PM Francisco Jerez wrote: > > "Rafael J. Wysocki" writes: > > > On Wed, Jul 15, 2020 at 2:09 AM Francisco Jerez > > wrote: > >> > >> "Rafael J. Wysocki" writes: > >> > >> > From: Rafael J. Wysocki > >> > > >> > Allow intel_pstate to work in the passive mode with

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-16 Thread Rafael J. Wysocki
On Wed, Jul 15, 2020 at 10:39 PM Doug Smythies wrote: > > On 2020.07.14 11:16 Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > ... > > Since the passive mode hasn't worked with HWP at all, and it is not going to > > the default for HWP systems anyway, I don't see any drawbacks related t

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-15 Thread Srinivas Pandruvada
On Wed, 2020-07-15 at 14:35 -0700, Francisco Jerez wrote: > "Rafael J. Wysocki" writes: > > > On Wed, Jul 15, 2020 at 2:09 AM Francisco Jerez < > > curroje...@riseup.net> wrote: > > > "Rafael J. Wysocki" writes: > > > > > > > From: Rafael J. Wysocki > > > > [...] > > > > I don't think that'

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-15 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > On Wed, Jul 15, 2020 at 2:09 AM Francisco Jerez wrote: >> >> "Rafael J. Wysocki" writes: >> >> > From: Rafael J. Wysocki >> > >> > Allow intel_pstate to work in the passive mode with HWP enabled and >> > make it set the HWP minimum performance limit (HWP floor) to

RE: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-15 Thread Doug Smythies
On 2020.07.14 11:16 Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki ... > Since the passive mode hasn't worked with HWP at all, and it is not going to > the default for HWP systems anyway, I don't see any drawbacks related to > making > this change, so I would consider this as 5.9 material

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-15 Thread Rafael J. Wysocki
On Wed, Jul 15, 2020 at 2:09 AM Francisco Jerez wrote: > > "Rafael J. Wysocki" writes: > > > From: Rafael J. Wysocki > > > > Allow intel_pstate to work in the passive mode with HWP enabled and > > make it set the HWP minimum performance limit (HWP floor) to the > > P-state value given by the tar

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-14 Thread Francisco Jerez
"Rafael J. Wysocki" writes: > From: Rafael J. Wysocki > > Allow intel_pstate to work in the passive mode with HWP enabled and > make it set the HWP minimum performance limit (HWP floor) to the > P-state value given by the target frequency supplied by the cpufreq > governor, so as to prevent the

[PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-14 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Allow intel_pstate to work in the passive mode with HWP enabled and make it set the HWP minimum performance limit (HWP floor) to the P-state value given by the target frequency supplied by the cpufreq governor, so as to prevent the HWP algorithm and the CPU scheduler from