On 13/06/2014 09:49 πμ, Doug Smythies wrote:
> On 2014.06.12 13:03 Rafael J. Wysocki wrote:
>> On Thursday, June 12, 2014 05:35:59 PM Stratos Karafotis wrote:
>>> On 12/06/2014 12:15 πμ, Doug Smythies wrote:
On 2014.06.11 13:20 Stratos Karafotis wrote:
> On 11/06/2014 06:02 μμ, D
essage-
>>>> From: Stratos Karafotis [mailto:strat...@semaphore.gr]
>>>> Sent: June-11-2014 13:20
>>>> To: Doug Smythies
>>>> Cc: linux...@vger.kernel.org; linux-kernel@vger.kernel.org;
>>>> r...@rjwysocki.net; viresh.ku...@linaro.org;
On 2014.06.12 06:49 Dirk Brandewie wrote:
> On 06/12/2014 01:03 PM, Rafael J. Wysocki wrote:
>> On Thursday, June 12, 2014 05:35:59 PM Stratos Karafotis wrote:
>>> On 12/06/2014 12:15 πμ, Doug Smythies wrote:
> Could you please elaborate a little bit more what we need these 2 lines
> bel
...@vger.kernel.org; linux-kernel@vger.kernel.org; r...@rjwysocki.net;
viresh.ku...@linaro.org; dirk.j.brande...@intel.com
Subject: Re: [PATCH] cpufreq: intel_pstate: Fix rounding of core_pct
On 2014.06.11 13:20 Stratos Karafotis wrote:
On 11/06/2014 06:02 μμ, Doug Smythies wrote:
On 2104.06.11
On 2014.06.12 13:03 Rafael J. Wysocki wrote:
> On Thursday, June 12, 2014 05:35:59 PM Stratos Karafotis wrote:
>> On 12/06/2014 12:15 πμ, Doug Smythies wrote:
>>>
>>>
>>> On 2014.06.11 13:20 Stratos Karafotis wrote:
On 11/06/2014 06:02 μμ, Doug Smythies wrote:
>
> On 2104.06.11 07:08
ythies
> > Cc: linux...@vger.kernel.org; linux-kernel@vger.kernel.org;
> > r...@rjwysocki.net; viresh.ku...@linaro.org; dirk.j.brande...@intel.com
> > Subject: Re: [PATCH] cpufreq: intel_pstate: Fix rounding of core_pct
> >
> > On 2014.06.11 13:20 Stratos Karafotis wr
viresh.ku...@linaro.org; dirk.j.brande...@intel.com
> Subject: Re: [PATCH] cpufreq: intel_pstate: Fix rounding of core_pct
>
> On 2014.06.11 13:20 Stratos Karafotis wrote:
>> On 11/06/2014 06:02 μμ, Doug Smythies wrote:
>>>
>>> On 2104.06.11 07:08 Stratos Karafoti
On 2014.06.11 14:45 Rafael J. Wysocki wrote:
> On Wed, Jun 11, 2014 at 11:40 PM, Doug Smythies wrote:
>
>> Myself, I consider the issue of excessive deferred timer times to be a much
>> higher priority (see my on-list e-mail from Monday). Correct me if I am
>> wrong.
>> Even without the "excess
rg; Linux Kernel Mailing List;
> Rafael J. Wysocki; viresh.ku...@linaro.org; dirk.j.brande...@intel.com
> Subject: Re: [PATCH] cpufreq: intel_pstate: Fix rounding of core_pct
>
> On 2014.06.11 11:29 Rafael J. Wysocki wrote:
>> On Wed, Jun 11, 2014 at 5:02 PM, Doug Smythies wrote:
...@intel.com
Subject: Re: [PATCH] cpufreq: intel_pstate: Fix rounding of core_pct
On 2014.06.11 11:29 Rafael J. Wysocki wrote:
> On Wed, Jun 11, 2014 at 5:02 PM, Doug Smythies wrote:
>> On 2104.06.11 07:08 Stratos Karafotis wrote:
>>> On 11/06/2014 04:41 μμ, Doug Smythies
: intel_pstate: Fix rounding of core_pct
On 2014.06.11 13:20 Stratos Karafotis wrote:
> On 11/06/2014 06:02 μμ, Doug Smythies wrote:
>>
>> On 2104.06.11 07:08 Stratos Karafotis wrote:
>>> On 11/06/2014 04:41 μμ, Doug Smythies wrote:
>>>
>>> No.
>>
>>&
On 11/06/2014 06:02 μμ, Doug Smythies wrote:
>
> On 2104.06.11 07:08 Stratos Karafotis wrote:
>> On 11/06/2014 04:41 μμ, Doug Smythies wrote:
>>
>> No.
>>
>> The intent was only ever to round properly the pseudo floating point result
>> of the divide.
>> It was much more important (ugh, well 4 ti
On Wed, Jun 11, 2014 at 5:02 PM, Doug Smythies wrote:
>
> On 2104.06.11 07:08 Stratos Karafotis wrote:
>> On 11/06/2014 04:41 μμ, Doug Smythies wrote:
>>
>> No.
>>
>> The intent was only ever to round properly the pseudo floating point result
>> of the divide.
>> It was much more important (ugh,
On 2104.06.11 07:08 Stratos Karafotis wrote:
> On 11/06/2014 04:41 μμ, Doug Smythies wrote:
>
> No.
>
> The intent was only ever to round properly the pseudo floating point result
> of the divide.
> It was much more important (ugh, well 4 times more) when FRACBITS was still
> 6, which also got
On 2014.06.11 06:42 Doug Smythies wrote:
On 2014.06.11 05:34 Stratos Karafotis wrote:
>> if ((rem << 1) >= int_tofp(sample->mperf))
>> -core_pct += 1;
>> +core_pct += int_tofp(1);
>>
>> sample->freq = fp_toint(
>> mul_fp(int_tofp(cpu->pstate.max_pst
On 11/06/2014 04:41 μμ, Doug Smythies wrote:
>
> On 2014.06.11 05:34 Stratos Karafotis wrote:
>
>> Local variable core_pct holds fixed point values.
>> When we round it we add "1" to core_pct. This has almost
>> no effect.
>>
>> So, add int_toftp(1) to core_pct when rounding.
>>
>> For example, i
On 2014.06.11 05:34 Stratos Karafotis wrote:
> Local variable core_pct holds fixed point values.
> When we round it we add "1" to core_pct. This has almost
> no effect.
>
> So, add int_toftp(1) to core_pct when rounding.
>
> For example, in a given sample point (values taken from
> tracepoint) wi
Local variable core_pct holds fixed point values.
When we round it we add "1" to core_pct. This has almost
no effect.
So, add int_toftp(1) to core_pct when rounding.
For example, in a given sample point (values taken from
tracepoint) with:
aperf = 5024
mperf = 10619
the core_pct is (before round
18 matches
Mail list logo
