On 27 August 2013 00:07, Stratos Karafotis wrote:
> Function __cpufreq_driver_target checks if target_freq is within
> policy->min and policy->max range. generic_powersave_bias_target also
> checks if target_freq is valid through cpufreq_frequency_table_target
> call. So, drop the unnecessary dupl
27 August 2013 23:04, Stratos Karafotis wrote:
> I'm sorry. Let me try to explain this better.
Don't be :)
> With my patch, dbs_info->requested_freq will not be capped within
> policy->min and policy->max in cs_check_cpu.
> So, temporarily it may have a value greater than policy->max
> or lower
On 08/27/2013 07:07 PM, Viresh Kumar wrote:
On 27 August 2013 21:16, Stratos Karafotis wrote:
I think we should keep these checks because:
1) They shorten the execution code (there is no unnecessary call of
__cpufreq_driver_target)
I don't really count this one.. This is how code is present
On 27 August 2013 21:16, Stratos Karafotis wrote:
> I think we should keep these checks because:
>
> 1) They shorten the execution code (there is no unnecessary call of
> __cpufreq_driver_target)
I don't really count this one.. This is how code is present everywhere in
kernel.. These checks are p
On 08/27/2013 08:57 AM, Viresh Kumar wrote:
> On 27 August 2013 00:07, Stratos Karafotis wrote:
>> drivers/cpufreq/cpufreq_conservative.c | 4
>
> Get rid of few more checks..
>
> /* if we are already at full speed then break out early */
> if (dbs_info->requested_freq == policy->max)
> re
On 27 August 2013 00:07, Stratos Karafotis wrote:
> drivers/cpufreq/cpufreq_conservative.c | 4
Get rid of few more checks..
/* if we are already at full speed then break out early */
if (dbs_info->requested_freq == policy->max)
return;
/*
* if we cannot reduce the frequency anymore, brea
Function __cpufreq_driver_target checks if target_freq is within
policy->min and policy->max range. generic_powersave_bias_target also
checks if target_freq is valid through cpufreq_frequency_table_target
call. So, drop the unnecessary duplicate check in *_check_cpu functions.
Signed-off-by: Strat
7 matches
Mail list logo
