Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-07-14 Thread Srivatsa S. Bhat
On 07/13/2013 06:22 PM, Paul Bolle wrote: > On Sat, 2013-07-13 at 12:16 +0200, Paul Bolle wrote: >> I suspect that the stuck frequency is a regression introduced in v3.10.0. > > The culprit apparently is commit a66b2e503f ("cpufreq: Preserve sysfs > files across suspend/resume"). Srivatsa submitte

Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-07-13 Thread Paul Bolle
On Sat, 2013-07-13 at 12:16 +0200, Paul Bolle wrote: > I suspect that the stuck frequency is a regression introduced in v3.10.0. The culprit apparently is commit a66b2e503f ("cpufreq: Preserve sysfs files across suspend/resume"). Srivatsa submitted a patch to revert that commit (see https://lkml.o

Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-07-13 Thread Paul Bolle
On Wed, 2013-07-10 at 22:50 +0200, Toralf Förster wrote: > I tested the patch several times on top of a66b2e5 - the origin issue is > fixed Srivatsa's patch became commit f51e1eb63d ("cpufreq: Fix cpufreq regression after suspend/resume"). > but - erratically another issue now appears : all 4 co

Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-07-11 Thread Srivatsa S. Bhat
On 07/11/2013 07:53 PM, Alan Stern wrote: > On Thu, 11 Jul 2013, Srivatsa S. Bhat wrote: > >> Oops! You are right. Hmm, this looks quite difficult to get right :( >> There are multiple challenges here: >> >> 1. The sysfs files must not be removed during cpu_down, and not initialized >> >>durin

Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-07-11 Thread Srivatsa S. Bhat
On 07/11/2013 07:33 PM, Lan Tianyu wrote: > 2013/7/11 Srivatsa S. Bhat : >> I tried to address all these in this patch, but you found yet another serious >> loop-hole. I guess I'm out of ideas now... if anybody has any thoughts on how >> to get this right, then I'm all ears. Else, we'll just reve

Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-07-11 Thread Alan Stern
On Thu, 11 Jul 2013, Srivatsa S. Bhat wrote: > Oops! You are right. Hmm, this looks quite difficult to get right :( > There are multiple challenges here: > > 1. The sysfs files must not be removed during cpu_down, and not initialized > >during cpu_up. That would help us preserve the file per

Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-07-11 Thread Lan Tianyu
2013/7/11 Srivatsa S. Bhat : > On 07/11/2013 11:10 AM, Lan Tianyu wrote: >> 2013/7/11 Srivatsa S. Bhat : > Oops! You are right. Hmm, this looks quite difficult to get right :( > There are multiple challenges here: If I understand correctly, the most concern is how to deal with per cpus' cpufreq_po

Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-07-10 Thread Srivatsa S. Bhat
On 07/11/2013 11:10 AM, Lan Tianyu wrote: > 2013/7/11 Srivatsa S. Bhat : >> Hi Toralf, >> >> On 07/11/2013 02:20 AM, Toralf Förster wrote: >>> I tested the patch several times on top of a66b2e5 - the origin issue is >>> fixed but - erratically another issue now appears : all 4 cores are runs >>> af

Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-07-10 Thread Lan Tianyu
2013/7/11 Srivatsa S. Bhat : > Hi Toralf, > > On 07/11/2013 02:20 AM, Toralf Förster wrote: >> I tested the patch several times on top of a66b2e5 - the origin issue is >> fixed but - erratically another issue now appears : all 4 cores are runs >> after wakeup at 2.6 GHz. >> The temporary hot fix is

Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-07-10 Thread Srivatsa S. Bhat
Hi Toralf, On 07/11/2013 02:20 AM, Toralf Förster wrote: > I tested the patch several times on top of a66b2e5 - the origin issue is > fixed but - erratically another issue now appears : all 4 cores are runs > after wakeup at 2.6 GHz. > The temporary hot fix is to switch between governor performanc

Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-07-10 Thread Toralf Förster
; > > ----------------------------- > > From: Srivatsa S. Bhat > Subject: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume > > Toralf Förster reported that the cpufreq ondemand governor behaves erratically > (doesn

Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-06-30 Thread Rafael J. Wysocki
So here is the proper patch, with changelog added. > > Regards, > Srivatsa S. Bhat > > > ----------------------------- > > From: Srivatsa S. Bhat > Subject: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume > > Toralf Förster reported that th

[PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-06-30 Thread Srivatsa S. Bhat
rom: Srivatsa S. Bhat Subject: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume Toralf Förster reported that the cpufreq ondemand governor behaves erratically (doesn't scale well) after a suspend/resume cycle. The problem was that the cpufreq subsystem's idea of the cpu fr