Re: [PATCH] compiler.h: update definition of unreachable()

2018-10-15 Thread Miguel Ojeda
On Mon, Oct 15, 2018 at 10:13 PM Nick Desaulniers wrote: > > Looking at commit cb984d101b30 ("compiler-gcc: integrate the various > compiler-gcc[345].h files") it seems that the comment is referring to > gcc 4.4 not supporting __builtin_unreachable(). Looks like it was > added in 4.5 timeframe: h

Re: [PATCH] compiler.h: update definition of unreachable()

2018-10-15 Thread Nick Desaulniers
On Mon, Oct 15, 2018 at 11:21 AM Miguel Ojeda wrote: > > On Mon, Oct 15, 2018 at 7:22 PM wrote: > > > > Fixes the objtool warning seen with Clang: > > arch/x86/mm/fault.o: warning: objtool: no_context()+0x220: unreachable > > instruction > > > > Fixes commit 815f0ddb346c ("include/linux/compiler*

Re: [PATCH] compiler.h: update definition of unreachable()

2018-10-15 Thread Miguel Ojeda
On Mon, Oct 15, 2018 at 7:22 PM wrote: > > Fixes the objtool warning seen with Clang: > arch/x86/mm/fault.o: warning: objtool: no_context()+0x220: unreachable > instruction > > Fixes commit 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h > mutually exclusive") > > Josh noted that the f

[PATCH] compiler.h: update definition of unreachable()

2018-10-15 Thread ndesaulniers
Fixes the objtool warning seen with Clang: arch/x86/mm/fault.o: warning: objtool: no_context()+0x220: unreachable instruction Fixes commit 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually exclusive") Josh noted that the fallback definition was meant to work around a pre-gcc-4.