Re: [PATCH] compiler: Don't perform compiletime_assert with -O0.

2017-08-30 Thread Joe Stringer
On 30 August 2017 at 19:16, Michael Ellerman wrote: > Joe Stringer writes: > >> On 30 August 2017 at 15:59, Andrew Morton wrote: >>> On Tue, 29 Aug 2017 16:01:14 -0700 Joe Stringer wrote: >>> Recent changes[0] to make use of __compiletime_assert() from container_of() increased the usa

Re: [PATCH] compiler: Don't perform compiletime_assert with -O0.

2017-08-30 Thread Michael Ellerman
Joe Stringer writes: > On 30 August 2017 at 15:59, Andrew Morton wrote: >> On Tue, 29 Aug 2017 16:01:14 -0700 Joe Stringer wrote: >> >>> Recent changes[0] to make use of __compiletime_assert() from >>> container_of() increased the usage of this macro, allowing developers to >>> notice type conf

Re: [PATCH] compiler: Don't perform compiletime_assert with -O0.

2017-08-30 Thread Joe Stringer
On 30 August 2017 at 15:59, Andrew Morton wrote: > On Tue, 29 Aug 2017 16:01:14 -0700 Joe Stringer wrote: > >> Recent changes[0] to make use of __compiletime_assert() from >> container_of() increased the usage of this macro, allowing developers to >> notice type conflicts in usage of container_of

Re: [PATCH] compiler: Don't perform compiletime_assert with -O0.

2017-08-30 Thread Andrew Morton
On Tue, 29 Aug 2017 16:01:14 -0700 Joe Stringer wrote: > Recent changes[0] to make use of __compiletime_assert() from > container_of() increased the usage of this macro, allowing developers to > notice type conflicts in usage of container_of() at compile time. > However, the implementation of __c

Re: [PATCH] compiler: Don't perform compiletime_assert with -O0.

2017-08-30 Thread Joe Stringer
On 30 August 2017 at 03:26, Michal Nazarewicz wrote: > On Tue, Aug 29 2017, Joe Stringer wrote: >> Recent changes[0] to make use of __compiletime_assert() from >> container_of() increased the usage of this macro, allowing developers to >> notice type conflicts in usage of container_of() at compile

Re: [PATCH] compiler: Don't perform compiletime_assert with -O0.

2017-08-30 Thread Michal Nazarewicz
On Tue, Aug 29 2017, Joe Stringer wrote: > Recent changes[0] to make use of __compiletime_assert() from > container_of() increased the usage of this macro, allowing developers to > notice type conflicts in usage of container_of() at compile time. > However, the implementation of __compiletime_asser

[PATCH] compiler: Don't perform compiletime_assert with -O0.

2017-08-29 Thread Joe Stringer
Recent changes[0] to make use of __compiletime_assert() from container_of() increased the usage of this macro, allowing developers to notice type conflicts in usage of container_of() at compile time. However, the implementation of __compiletime_assert relies on compiler optimizations to report an e