Re: [PATCH] compat_audit: allow it to work without asm/unistd32.h

2014-03-25 Thread Chris Metcalf
On 3/24/2014 10:16 PM, AKASHI Takahiro wrote: > On 03/25/2014 01:39 AM, Chris Metcalf wrote: >> The problem is that audit_is_compat() is a dynamic test that the compiler >> can't optimize away, so you end with an undefined reference to >> audit_classify_compat_syscall(). >> >> > > [...] > I prefer

Re: [PATCH] compat_audit: allow it to work without asm/unistd32.h

2014-03-24 Thread AKASHI Takahiro
On 03/25/2014 01:39 AM, Chris Metcalf wrote: The problem is that audit_is_compat() is a dynamic test that the compiler can't optimize away, so you end with an undefined reference to audit_classify_compat_syscall(). For some reason audit_classify_compat_syscall() is declared as __weak in ; usuall

Re: [PATCH] compat_audit: allow it to work without asm/unistd32.h

2014-03-24 Thread Chris Metcalf
The problem is that audit_is_compat() is a dynamic test that the compiler can't optimize away, so you end with an undefined reference to audit_classify_compat_syscall(). For some reason audit_classify_compat_syscall() is declared as __weak in ; usually the __weak tag is only provided on the defin

Re: [PATCH] compat_audit: allow it to work without asm/unistd32.h

2014-03-24 Thread Eric Paris
I don't know tilegx, but I have replaced 223b24d807610 with 4b58841149dcaa5. I believe adding AUDIT_ARCH_COMPAT_GENERIC was akashi-san's fix for this problem on mips. Is this a better fix? Thanks -Eric On Thu, 2014-03-20 at 11:31 -0400, Chris Metcalf wrote: > For architectures that use the asm

[PATCH] compat_audit: allow it to work without asm/unistd32.h

2014-03-20 Thread Chris Metcalf
For architectures that use the asm-generic syscall table for both 32- and 64-bit, there should be no need to provide a separate ; just using is sufficient. Conditionalize use of on the one platform that currently requires it (arm64). If another platform ends up needing it we can create a suitabl