Re: [PATCH] compaction: fix isolate_migratepages_block() for THP=n

2015-06-03 Thread Kirill A. Shutemov
On Wed, Jun 03, 2015 at 11:14:05AM +0200, Vlastimil Babka wrote: > On 04/29/2015 12:44 AM, Kirill A. Shutemov wrote: > >>> > >>> I wrote this to fix bug I originally attributed to refcounting patchset, > >>> but Sasha triggered the same bug on -next without the patchset applied: > >>> > >>> http://

Re: [PATCH] compaction: fix isolate_migratepages_block() for THP=n

2015-06-03 Thread Vlastimil Babka
On 04/29/2015 12:44 AM, Kirill A. Shutemov wrote: >>> >>> I wrote this to fix bug I originally attributed to refcounting patchset, >>> but Sasha triggered the same bug on -next without the patchset applied: >>> >>> http://lkml.kernel.org/g/553eb993.7030...@oracle.com >> >> Well why the heck didn't

Re: [PATCH] compaction: fix isolate_migratepages_block() for THP=n

2015-04-28 Thread Kirill A. Shutemov
On Tue, Apr 28, 2015 at 03:37:24PM -0700, Andrew Morton wrote: > On Wed, 29 Apr 2015 01:28:28 +0300 "Kirill A. Shutemov" > wrote: > > > On Tue, Apr 28, 2015 at 03:14:20PM -0700, Andrew Morton wrote: > > > On Mon, 27 Apr 2015 14:26:46 +0300 "Kirill A. Shutemov" > > > wrote: > > > > > > > PageT

Re: [PATCH] compaction: fix isolate_migratepages_block() for THP=n

2015-04-28 Thread Andrew Morton
On Wed, 29 Apr 2015 01:28:28 +0300 "Kirill A. Shutemov" wrote: > On Tue, Apr 28, 2015 at 03:14:20PM -0700, Andrew Morton wrote: > > On Mon, 27 Apr 2015 14:26:46 +0300 "Kirill A. Shutemov" > > wrote: > > > > > PageTrans* helpers are always-false if THP is disabled compile-time. > > > It means

Re: [PATCH] compaction: fix isolate_migratepages_block() for THP=n

2015-04-28 Thread Kirill A. Shutemov
On Tue, Apr 28, 2015 at 03:14:20PM -0700, Andrew Morton wrote: > On Mon, 27 Apr 2015 14:26:46 +0300 "Kirill A. Shutemov" > wrote: > > > PageTrans* helpers are always-false if THP is disabled compile-time. > > It means the fucntion will fail to detect hugetlb pages in this case. > > > > Let's us

Re: [PATCH] compaction: fix isolate_migratepages_block() for THP=n

2015-04-28 Thread Andrew Morton
On Mon, 27 Apr 2015 14:26:46 +0300 "Kirill A. Shutemov" wrote: > PageTrans* helpers are always-false if THP is disabled compile-time. > It means the fucntion will fail to detect hugetlb pages in this case. > > Let's use PageCompound() instead. With small tweak to how we calculate > next low_pfn

Re: [PATCH] compaction: fix isolate_migratepages_block() for THP=n

2015-04-27 Thread Vlastimil Babka
On 27.4.2015 13:26, Kirill A. Shutemov wrote: > PageTrans* helpers are always-false if THP is disabled compile-time. > It means the fucntion will fail to detect hugetlb pages in this case. > > Let's use PageCompound() instead. With small tweak to how we calculate > next low_pfn it will make functi

[PATCH] compaction: fix isolate_migratepages_block() for THP=n

2015-04-27 Thread Kirill A. Shutemov
PageTrans* helpers are always-false if THP is disabled compile-time. It means the fucntion will fail to detect hugetlb pages in this case. Let's use PageCompound() instead. With small tweak to how we calculate next low_pfn it will make function ready to see tail pages. Signed-off-by: Kirill A. Sh