Re: [PATCH] comedi: ni_6527: Fix coding style - use BIT macro

2015-11-18 Thread Ian Abbott
On 16/11/15 16:56, Ranjith Thangavel wrote: BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/ni_6527.c | 24 1 file changed, 12 insertions(+), 12 deleti

Re: [PATCH] comedi: ni_6527: Fix coding style - use BIT macro

2015-11-18 Thread Ian Abbott
On 14/11/15 13:13, Ranjith Thangavel wrote: BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/ni_6527.c | 27 ++- 1 file changed, 14 insertions(+), 13 del

[PATCH] comedi: ni_6527: Fix coding style - use BIT macro

2015-11-16 Thread Ranjith Thangavel
BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/ni_6527.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/comedi/driv

Re: [PATCH] comedi: ni_6527: Fix coding style - use BIT macro

2015-11-16 Thread Dan Carpenter
On Sat, Nov 14, 2015 at 06:43:23PM +0530, Ranjith Thangavel wrote: > @@ -221,11 +223,11 @@ static int ni6527_intr_cmdtest(struct comedi_device > *dev, > > /* Step 1 : check if triggers are trivially valid */ > > - err |= comedi_check_trigger_src(&cmd->start_src, TRIG_NOW); > - er

[PATCH] comedi: ni_6527: Fix coding style - use BIT macro

2015-11-14 Thread Ranjith Thangavel
BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/ni_6527.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/staging/comedi/d

Re: [PATCH] comedi: ni_6527: Fix coding style - use BIT macro

2015-11-12 Thread Ian Abbott
On 11/11/15 16:14, Ranjith Thangavel wrote: BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/ni_6527.c | 24 1 file changed, 12 insertions(+), 12 deleti

[PATCH] comedi: ni_6527: Fix coding style - use BIT macro

2015-11-11 Thread Ranjith Thangavel
BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/ni_6527.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/comedi/driv

[PATCH] comedi: ni_6527: Fix coding style - use BIT macro

2015-11-09 Thread Ranjith T
BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith T --- drivers/staging/comedi/drivers/ni_6527.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_6