Re: [PATCH] colons are invalid characters in netdev names

2015-02-17 Thread Matthew Thode
On 02/17/2015 07:28 PM, Stephen Hemminger wrote: > On Tue, 17 Feb 2015 17:15:42 -0600 > Matthew Thode wrote: > >> colons are used as a separator in netdev device lookup in dev_ioctl.c >> >> Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME >> >> Signed-off-by: Matthew Thode > > What

Re: [PATCH] colons are invalid characters in netdev names

2015-02-17 Thread Stephen Hemminger
On Tue, 17 Feb 2015 17:15:42 -0600 Matthew Thode wrote: > colons are used as a separator in netdev device lookup in dev_ioctl.c > > Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME > > Signed-off-by: Matthew Thode What is the exact sequence that causes the problem? SIOCSIFNAME alr

Re: [PATCH] colons are invalid characters in netdev names

2015-02-17 Thread Lino Sanfilippo
On 18.02.2015 00:57, Matthew Thode wrote: >> > You are correct, should I resend a patch. Not really sure the > procedure of updating a patchset sent to the ML. > You could resend as [PATCH v2] to indicate that it is an updated version. But you should also try to improve the patch subject line

Re: [PATCH] colons are invalid characters in netdev names

2015-02-17 Thread Matthew Thode
On 02/17/2015 05:46 PM, Lino Sanfilippo wrote: > On 18.02.2015 00:15, Matthew Thode wrote: >> colons are used as a separator in netdev device lookup in dev_ioctl.c >> >> Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME >> >> Signed-off-by: Matthew Thode >> --- >> net/core/dev.c | 2 +-

Re: [PATCH] colons are invalid characters in netdev names

2015-02-17 Thread Lino Sanfilippo
On 18.02.2015 00:15, Matthew Thode wrote: > colons are used as a separator in netdev device lookup in dev_ioctl.c > > Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME > > Signed-off-by: Matthew Thode > --- > net/core/dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[PATCH] colons are invalid characters in netdev names

2015-02-17 Thread Matthew Thode
colons are used as a separator in netdev device lookup in dev_ioctl.c Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME Signed-off-by: Matthew Thode --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index d030575..e