Re: [PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency

2017-11-15 Thread Julia Lawall
On Wed, 15 Nov 2017, Joe Perches wrote: > On Wed, 2017-11-15 at 22:55 +0100, Julia Lawall wrote: > > What version of Coccinelle do you have? > > > I tried 1.0.4 and 1.0.6, > > > but both failed. > > For me, it also fails for 1.0.6. It should be OK for 1.0.7. > > Then likely this patch should no

Re: [PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency

2017-11-15 Thread Masahiro Yamada
2017-11-16 7:02 GMT+09:00 Joe Perches : > On Wed, 2017-11-15 at 22:55 +0100, Julia Lawall wrote: >> What version of Coccinelle do you have? >> > I tried 1.0.4 and 1.0.6, >> > but both failed. >> For me, it also fails for 1.0.6. It should be OK for 1.0.7. > > Then likely this patch should not be ap

Re: [PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency

2017-11-15 Thread Joe Perches
On Wed, 2017-11-15 at 22:55 +0100, Julia Lawall wrote: > What version of Coccinelle do you have? > > I tried 1.0.4 and 1.0.6, > > but both failed. > For me, it also fails for 1.0.6. It should be OK for 1.0.7. Then likely this patch should not be applied or some form of local version checking shou

Re: [PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency

2017-11-15 Thread Julia Lawall
On Thu, 16 Nov 2017, Masahiro Yamada wrote: > Hi Julia, > > > 2017-11-15 23:51 GMT+09:00 Julia Lawall : > > > > > > On Wed, 15 Nov 2017, Masahiro Yamada wrote: > > > >> Hi Julia, > >> > >> > >> 2017-11-13 1:08 GMT+09:00 Julia Lawall : > >> > An initial rule just matching a function call makes it

Re: [PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency

2017-11-15 Thread Julia Lawall
On Thu, 16 Nov 2017, Masahiro Yamada wrote: > Hi Julia, > > > 2017-11-15 23:51 GMT+09:00 Julia Lawall : > > > > > > On Wed, 15 Nov 2017, Masahiro Yamada wrote: > > > >> Hi Julia, > >> > >> > >> 2017-11-13 1:08 GMT+09:00 Julia Lawall : > >> > An initial rule just matching a function call makes it

Re: [PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency

2017-11-15 Thread Masahiro Yamada
Hi Julia, 2017-11-15 23:51 GMT+09:00 Julia Lawall : > > > On Wed, 15 Nov 2017, Masahiro Yamada wrote: > >> Hi Julia, >> >> >> 2017-11-13 1:08 GMT+09:00 Julia Lawall : >> > An initial rule just matching a function call makes it possible to focus >> > on one all at a time, which improves performanc

Re: [PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency

2017-11-15 Thread Julia Lawall
On Wed, 15 Nov 2017, Masahiro Yamada wrote: > Hi Julia, > > > 2017-11-13 1:08 GMT+09:00 Julia Lawall : > > An initial rule just matching a function call makes it possible to focus > > on one all at a time, which improves performance in complex functions with > > multiple locking calls. Using a

Re: [PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency

2017-11-15 Thread Masahiro Yamada
Hi Julia, 2017-11-13 1:08 GMT+09:00 Julia Lawall : > An initial rule just matching a function call makes it possible to focus > on one all at a time, which improves performance in complex functions with > multiple locking calls. Using a constraint expression lock2 != pre.lock1; > makes it possib

[PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency

2017-11-12 Thread Julia Lawall
An initial rule just matching a function call makes it possible to focus on one all at a time, which improves performance in complex functions with multiple locking calls. Using a constraint expression lock2 != pre.lock1; makes it possible to eliminate the double matching of the lock, lock sequenc