Re: [PATCH] clk: sunxi: fix devm_ioremap_resource error detection code

2014-07-01 Thread Mike Turquette
Quoting Emilio López (2014-06-28 14:38:26) > Hi, > > El 28/06/14 14:58, Boris BREZILLON escribió: > > Hello, > > > > On 28/06/2014 19:23, Himangi Saraogi wrote: > >> devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure. > >> > >> A simplified version of the semantic match that find

Re: [PATCH] clk: sunxi: fix devm_ioremap_resource error detection code

2014-06-28 Thread Emilio López
Hi, El 28/06/14 14:58, Boris BREZILLON escribió: Hello, On 28/06/2014 19:23, Himangi Saraogi wrote: devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure. A simplified version of the semantic match that finds this problem is as follows: // @@ expression e,e1; statement S; @@

[PATCH] clk: sunxi: fix devm_ioremap_resource error detection code

2014-06-28 Thread Himangi Saraogi
devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure. A simplified version of the semantic match that finds this problem is as follows: // @@ expression e,e1; statement S; @@ *e = devm_ioremap_resource(...); if (!e1) S // Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall