Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-07 Thread Sebastian Hesselbarth
On 10/06/2013 11:04 PM, Mike Turquette wrote: On Sun, Oct 6, 2013 at 3:24 PM, Sebastian Hesselbarth wrote: Of course, we can do clk_enable, read, clk_disable as said before - and given the amount of questions and misinterpretation, I think it is the saner way. Sorry for any misinterpretation

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-06 Thread Andrew Lunn
> Andrew has mentioned, that some bootloaders might disable clocks but > leave the nodes enabled. Reading those registers would lock up > the HW, of course. So we thought about to check clk gate status first, > which this patch is about. > > Of course, we can do clk_enable, read, clk_disable as sa

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-06 Thread Mike Turquette
On Sun, Oct 6, 2013 at 3:24 PM, Sebastian Hesselbarth wrote: > On 10/06/2013 10:02 PM, Mike Turquette wrote: >> >> Quoting Sebastian Hesselbarth (2013-10-06 12:42:01) >>> >>> On 10/06/2013 06:30 PM, Andrew Lunn wrote: On Sun, Oct 06, 2013 at 11:06:09AM +0200, Gerhard Sittig wrote: >

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-06 Thread Sebastian Hesselbarth
On 10/06/2013 10:02 PM, Mike Turquette wrote: Quoting Sebastian Hesselbarth (2013-10-06 12:42:01) On 10/06/2013 06:30 PM, Andrew Lunn wrote: On Sun, Oct 06, 2013 at 11:06:09AM +0200, Gerhard Sittig wrote: What's wrong with an explicit enable/disable around the data acquisition? It avoids the

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-06 Thread Mike Turquette
Quoting Sebastian Hesselbarth (2013-10-06 12:42:01) > On 10/06/2013 06:30 PM, Andrew Lunn wrote: > > On Sun, Oct 06, 2013 at 11:06:09AM +0200, Gerhard Sittig wrote: > >> On Sat, Oct 05, 2013 at 22:42 +0200, Andrew Lunn wrote: > >>> > >>> On Sat, Oct 05, 2013 at 10:24:30PM +0200, Uwe Kleine-König wr

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-06 Thread Sebastian Hesselbarth
On 10/06/2013 06:30 PM, Andrew Lunn wrote: On Sun, Oct 06, 2013 at 11:06:09AM +0200, Gerhard Sittig wrote: On Sat, Oct 05, 2013 at 22:42 +0200, Andrew Lunn wrote: On Sat, Oct 05, 2013 at 10:24:30PM +0200, Uwe Kleine-König wrote: On Fri, Oct 04, 2013 at 12:08:30PM +0200, Sebastian Hesselbarth

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-06 Thread Andrew Lunn
On Sun, Oct 06, 2013 at 11:06:09AM +0200, Gerhard Sittig wrote: > On Sat, Oct 05, 2013 at 22:42 +0200, Andrew Lunn wrote: > > > > On Sat, Oct 05, 2013 at 10:24:30PM +0200, Uwe Kleine-König wrote: > > > On Fri, Oct 04, 2013 at 12:08:30PM +0200, Sebastian Hesselbarth wrote: > > > > To determine if a

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-06 Thread Gerhard Sittig
On Sat, Oct 05, 2013 at 22:42 +0200, Andrew Lunn wrote: > > On Sat, Oct 05, 2013 at 10:24:30PM +0200, Uwe Kleine-König wrote: > > On Fri, Oct 04, 2013 at 12:08:30PM +0200, Sebastian Hesselbarth wrote: > > > To determine if a clk has been previously enabled, provide a public > > > clk_is_enabled fu

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-05 Thread Andrew Lunn
On Sat, Oct 05, 2013 at 10:24:30PM +0200, Uwe Kleine-König wrote: > On Fri, Oct 04, 2013 at 12:08:30PM +0200, Sebastian Hesselbarth wrote: > > To determine if a clk has been previously enabled, provide a public > > clk_is_enabled function. This is especially helpful to check the state > > of clk-ga

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-05 Thread Uwe Kleine-König
On Fri, Oct 04, 2013 at 12:08:30PM +0200, Sebastian Hesselbarth wrote: > To determine if a clk has been previously enabled, provide a public > clk_is_enabled function. This is especially helpful to check the state > of clk-gate without actually changing the state of the gate. I wonder what you want

Re: [PATCH] clk: provide public clk_is_enabled function

2013-10-04 Thread Andrew Lunn
On Fri, Oct 04, 2013 at 12:08:30PM +0200, Sebastian Hesselbarth wrote: > To determine if a clk has been previously enabled, provide a public > clk_is_enabled function. This is especially helpful to check the state > of clk-gate without actually changing the state of the gate. > > Signed-off-by: Se

[PATCH] clk: provide public clk_is_enabled function

2013-10-04 Thread Sebastian Hesselbarth
To determine if a clk has been previously enabled, provide a public clk_is_enabled function. This is especially helpful to check the state of clk-gate without actually changing the state of the gate. Signed-off-by: Sebastian Hesselbarth --- Cc: Mike Turquette Cc: Russell King Cc: Jason Cooper