Re: [PATCH] cifs: remove redundant duplicated assignment of pointer 'node'

2018-01-18 Thread Steve French
hni...@lists.samba.org > Cc: kernel-janit...@vger.kernel.org, linux-kernel@vger.kernel.org > Sent: Wednesday, 17 January, 2018 8:52:39 PM > Subject: [PATCH] cifs: remove redundant duplicated assignment of pointer > 'node' > > From: Colin Ian King > > Node is assigned

Re: [PATCH] cifs: remove redundant duplicated assignment of pointer 'node'

2018-01-17 Thread Ronnie Sahlberg
ubject: [PATCH] cifs: remove redundant duplicated assignment of pointer 'node' From: Colin Ian King Node is assigned twice to rb_first(root), first during declaration time and second after a taking a spin lock, so we have a duplicated assignment. Remove the first assignment becaus

[PATCH] cifs: remove redundant duplicated assignment of pointer 'node'

2018-01-17 Thread Colin King
From: Colin Ian King Node is assigned twice to rb_first(root), first during declaration time and second after a taking a spin lock, so we have a duplicated assignment. Remove the first assignment because it is redundant and also not protected by the spin lock. Cleans up clang warning: fs/cifs/c