[PATCH] cifs: remove GLOBAL_EXTERN macro

2008-02-25 Thread Harvey Harrison
Global variables should be defined in C files, not in headers. 1) Comment out unused vars GlobalDnotifyRsp_Q GlobalUidList 2) Declare vars in cifsfs.c that need it and change to extern in cifsglob.h 3) Change to extern in cifsglob.h for vars that were already being declared in cifsfs.c 4) Remov

[PATCH] cifs: remove GLOBAL_EXTERN macro

2008-02-18 Thread Harvey Harrison
Global vaiables should be defined in C files, not in headers. 1) Comment out unused vars GlobalDnotifyRsp_Q GlobalUidList 2) Declare vars in cifsfs.c that need it and change to extern in cifsglob.h 3) Change to extern in cifsglob.h for vars that were already being declared in cifsfs.c 4) Remove

[RFC-PATCH] cifs: remove GLOBAL_EXTERN macro

2008-02-15 Thread Harvey Harrison
Just use extern, saves a lot of sparse warnings. fs/cifs/cifsglob.h:603:33: warning: symbol 'GlobalUidList' was not declared. Should it be static? fs/cifs/cifsglob.h:606:32: warning: symbol 'GlobalSMBSessionList' was not declared. Should it be static? fs/cifs/cifsglob.h:607:32: warning: symbol 'G