Re: [PATCH] cifs: misc: Use array_size() in if-statement controlling expression

2020-06-16 Thread Steve French
Added the two reviewed-bys and merged into cifs-2.6.git for-next On Tue, Jun 16, 2020 at 6:17 AM Aurélien Aptel via samba-technical wrote: > > Reviewed-by: Aurelien Aptel > > Cheers, > -- > Aurélien Aptel / SUSE Labs Samba Team > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > SUSE Sof

Re: [PATCH] cifs: misc: Use array_size() in if-statement controlling expression

2020-06-16 Thread Kees Cook
On Mon, Jun 15, 2020 at 05:41:12PM -0500, Gustavo A. R. Silva wrote: > Use array_size() instead of the open-coded version in the controlling > expression of the if statement. > > Also, while there, use the preferred form for passing a size of a struct. > The alternative form where struct name is s

Re: [PATCH] cifs: misc: Use array_size() in if-statement controlling expression

2020-06-16 Thread Aurélien Aptel
Reviewed-by: Aurelien Aptel Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

[PATCH] cifs: misc: Use array_size() in if-statement controlling expression

2020-06-15 Thread Gustavo A. R. Silva
Use array_size() instead of the open-coded version in the controlling expression of the if statement. Also, while there, use the preferred form for passing a size of a struct. The alternative form where struct name is spelled out hurts readability and introduces an opportunity for a bug when the p