Re: [PATCH] cifs: hide unused functions

2017-09-17 Thread Steve French
merged into cifs-2.6.git for-next On Sun, Sep 10, 2017 at 5:28 AM, Geert Uytterhoeven wrote: > On Tue, Sep 5, 2017 at 11:24 AM, Arnd Bergmann wrote: >> The newly added SMB2+ attribute support causes unused function >> warnings when CONFIG_CIFS_XATTR is disabled: >> >> fs/cifs/smb2ops.c:563:1: er

Re: [PATCH] cifs: hide unused functions

2017-09-10 Thread Geert Uytterhoeven
On Tue, Sep 5, 2017 at 11:24 AM, Arnd Bergmann wrote: > The newly added SMB2+ attribute support causes unused function > warnings when CONFIG_CIFS_XATTR is disabled: > > fs/cifs/smb2ops.c:563:1: error: 'smb2_set_ea' defined but not used > [-Werror=unused-function] > smb2_set_ea(const unsigned in

[PATCH] cifs: hide unused functions

2017-09-05 Thread Arnd Bergmann
The newly added SMB2+ attribute support causes unused function warnings when CONFIG_CIFS_XATTR is disabled: fs/cifs/smb2ops.c:563:1: error: 'smb2_set_ea' defined but not used [-Werror=unused-function] smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon, fs/cifs/smb2ops.c:513:1: error: 'sm

Re: [PATCH] cifs: hide unused functions

2017-06-27 Thread Steve French
merged into cifs-2.6.git for-next On Tue, Jun 27, 2017 at 10:06 AM, Arnd Bergmann wrote: > Some functions are only referenced under an #ifdef, causing a harmless > warning: > > fs/cifs/smb2ops.c:1374:1: error: 'get_smb2_acl' defined but not used > [-Werror=unused-function] > > We could mark them

[PATCH] cifs: hide unused functions

2017-06-27 Thread Arnd Bergmann
Some functions are only referenced under an #ifdef, causing a harmless warning: fs/cifs/smb2ops.c:1374:1: error: 'get_smb2_acl' defined but not used [-Werror=unused-function] We could mark them __maybe_unused or add another #ifdef, I picked the second approach here. Fixes: b3fdda4d1e1b ("cifs: