Re: [PATCH] checkpatch: don't require octal permissions for "0" in module_param

2017-12-13 Thread Bartosz Golaszewski
2017-12-11 11:48 GMT+01:00 Bartosz Golaszewski : > File permissions set to "0" in the module_param family of macros mean > that the parameter should not show up in sysfs. Don't require octal > permissions in this case. > > Signed-off-by: Bartosz Golaszewski > --- > scripts/checkpatch.pl | 2 +- >

[PATCH] checkpatch: don't require octal permissions for "0" in module_param

2017-12-11 Thread Bartosz Golaszewski
File permissions set to "0" in the module_param family of macros mean that the parameter should not show up in sysfs. Don't require octal permissions in this case. Signed-off-by: Bartosz Golaszewski --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scr

Re: [PATCH] checkpatch: don't require octal permissions for "0"

2017-12-11 Thread Bartosz Golaszewski
2017-12-11 3:19 GMT+01:00 Joe Perches : > On Sun, 2017-12-10 at 15:04 +0100, Bartosz Golaszewski wrote: >> If the permission value is 0, don't raise the NON_OCTAL_PERMISSIONS >> error. There's no possibility of an error if there are no permissions. >> >> Suggested-by: Andy Shevchenko >> Signed-off

Re: [PATCH] checkpatch: don't require octal permissions for "0"

2017-12-10 Thread Joe Perches
On Sun, 2017-12-10 at 15:04 +0100, Bartosz Golaszewski wrote: > If the permission value is 0, don't raise the NON_OCTAL_PERMISSIONS > error. There's no possibility of an error if there are no permissions. > > Suggested-by: Andy Shevchenko > Signed-off-by: Bartosz Golaszewski > --- > scripts/che

Re: [PATCH] checkpatch: don't require octal permissions for "0"

2017-12-10 Thread Joe Perches
On Sun, 2017-12-10 at 15:04 +0100, Bartosz Golaszewski wrote: > If the permission value is 0, don't raise the NON_OCTAL_PERMISSIONS > error. There's no possibility of an error if there are no permissions. Hi Bartosz This response below is the same as another email thread - Personall

[PATCH] checkpatch: don't require octal permissions for "0"

2017-12-10 Thread Bartosz Golaszewski
If the permission value is 0, don't raise the NON_OCTAL_PERMISSIONS error. There's no possibility of an error if there are no permissions. Suggested-by: Andy Shevchenko Signed-off-by: Bartosz Golaszewski --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git