Re: [PATCH] checkpatch: Avoid missing typo suggestions

2020-06-04 Thread Kees Cook
On Thu, Jun 04, 2020 at 06:02:05PM -0700, Joe Perches wrote: > Huh? Did you test this? I didn't, no. I was going off my earlier discoveries about how the "msdos" thing got parsed weird. My apologies! > $ ./scripts/checkpatch.pl --strict -f test_spell.c > CHECK: 'Cambridg' may be misspelled - pe

Re: [PATCH] checkpatch: Avoid missing typo suggestions

2020-06-04 Thread Joe Perches
On Thu, 2020-06-04 at 15:08 -0700, Kees Cook wrote: > On Wed, Jun 03, 2020 at 05:39:47PM -0700, Joe Perches wrote: > > On Wed, 2020-06-03 at 16:19 -0700, Kees Cook wrote: > > > My codespell dictionary has a lot of capitalized words. For example: > > > > > > MSDOS->MS-DOS > > > > > > Since checkpa

Re: [PATCH] checkpatch: Avoid missing typo suggestions

2020-06-04 Thread Kees Cook
On Wed, Jun 03, 2020 at 05:39:47PM -0700, Joe Perches wrote: > On Wed, 2020-06-03 at 16:19 -0700, Kees Cook wrote: > > My codespell dictionary has a lot of capitalized words. For example: > > > > MSDOS->MS-DOS > > > > Since checkpatch uses case-insensitive matching, I get an undefined > > variabl

Re: [PATCH] checkpatch: Avoid missing typo suggestions

2020-06-04 Thread Maxim Uvarov
On Thu, 4 Jun 2020 at 10:29, Joe Perches wrote: > > On Thu, 2020-06-04 at 09:55 +0300, Maxim Uvarov wrote: > > On Thu, 4 Jun 2020 at 03:39, Joe Perches wrote: > > Hi Maxim. > > > > btw: My codespell dictionary file moved to > > > /usr/lib/python3/dist-packages/codespell_lib/data/dictionary.txt >

Re: [PATCH] checkpatch: Avoid missing typo suggestions

2020-06-04 Thread Joe Perches
On Thu, 2020-06-04 at 09:55 +0300, Maxim Uvarov wrote: > On Thu, 4 Jun 2020 at 03:39, Joe Perches wrote: Hi Maxim. > > btw: My codespell dictionary file moved to > > /usr/lib/python3/dist-packages/codespell_lib/data/dictionary.txt > > > > and I had to use --codespell --codespellfile=(above) so

Re: [PATCH] checkpatch: Avoid missing typo suggestions

2020-06-03 Thread Maxim Uvarov
On Thu, 4 Jun 2020 at 03:39, Joe Perches wrote: > > On Wed, 2020-06-03 at 16:19 -0700, Kees Cook wrote: > > My codespell dictionary has a lot of capitalized words. For example: > > > > MSDOS->MS-DOS > > > > Since checkpatch uses case-insensitive matching, I get an undefined > > variable warning an

Re: [PATCH] checkpatch: Avoid missing typo suggestions

2020-06-03 Thread Joe Perches
On Wed, 2020-06-03 at 16:19 -0700, Kees Cook wrote: > My codespell dictionary has a lot of capitalized words. For example: > > MSDOS->MS-DOS > > Since checkpatch uses case-insensitive matching, I get an undefined > variable warning and then empty suggestions for things like this: > > Use of unin

[PATCH] checkpatch: Avoid missing typo suggestions

2020-06-03 Thread Kees Cook
My codespell dictionary has a lot of capitalized words. For example: MSDOS->MS-DOS Since checkpatch uses case-insensitive matching, I get an undefined variable warning and then empty suggestions for things like this: Use of uninitialized value $typo_fix in concatenation (.) or string at ./scrip