Re: [PATCH] cgroup: remove redundant check in cgroup_ino()

2014-09-19 Thread Tejun Heo
On Fri, Sep 19, 2014 at 04:29:31PM +0800, Zefan Li wrote: > After we implemented default unified hierarchy, cgrp->kn can never > be NULL. > > Signed-off-by: Zefan Li Applied to cgroup/for-3.18. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

[PATCH] cgroup: remove redundant check in cgroup_ino()

2014-09-19 Thread Zefan Li
After we implemented default unified hierarchy, cgrp->kn can never be NULL. Signed-off-by: Zefan Li --- include/linux/cgroup.h | 7 ++- mm/memory-failure.c| 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index 77a1d37.

Re: [PATCH] cgroup: remove redundant check

2012-12-20 Thread Sasha Levin
On 12/20/2012 02:18 PM, Tejun Heo wrote: > On Thu, Dec 20, 2012 at 02:11:31PM -0500, Sasha Levin wrote: >> We already know that 'event' is non-NULL, remove the redundant check. >> >> Signed-off-by: Sasha Levin > > I don't know. I kinda like that test there. It's not an error path > and tearing

Re: [PATCH] cgroup: remove redundant check

2012-12-20 Thread Tejun Heo
On Thu, Dec 20, 2012 at 02:11:31PM -0500, Sasha Levin wrote: > We already know that 'event' is non-NULL, remove the redundant check. > > Signed-off-by: Sasha Levin I don't know. I kinda like that test there. It's not an error path and tearing down everything which could have been allocated. I

[PATCH] cgroup: remove redundant check

2012-12-20 Thread Sasha Levin
We already know that 'event' is non-NULL, remove the redundant check. Signed-off-by: Sasha Levin --- kernel/cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/cgroup.c b/kernel/cgroup.c index 4855892..8d6c3f2 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@