Re: [PATCH] ceph: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-02 Thread Jeff Layton
On Tue, 2021-02-02 at 07:45 -0500, Jeff Layton wrote: > On Tue, 2021-02-02 at 13:07 +0100, Ilya Dryomov wrote: > > On Mon, Feb 1, 2021 at 8:52 AM Jiapeng Chong > > wrote: > > > > > > Fix the following coccicheck warning: > > > > > > ./fs/ceph/debugfs.c:347:0-23: WARNING: congestion_kb_fops shoul

Re: [PATCH] ceph: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-02 Thread Jeff Layton
On Tue, 2021-02-02 at 13:07 +0100, Ilya Dryomov wrote: > On Mon, Feb 1, 2021 at 8:52 AM Jiapeng Chong > wrote: > > > > Fix the following coccicheck warning: > > > > ./fs/ceph/debugfs.c:347:0-23: WARNING: congestion_kb_fops should be > > defined with DEFINE_DEBUGFS_ATTRIBUTE. > > > > Reported-by

Re: [PATCH] ceph: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-02 Thread Ilya Dryomov
On Mon, Feb 1, 2021 at 8:52 AM Jiapeng Chong wrote: > > Fix the following coccicheck warning: > > ./fs/ceph/debugfs.c:347:0-23: WARNING: congestion_kb_fops should be > defined with DEFINE_DEBUGFS_ATTRIBUTE. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > fs/ceph/debugfs.c |

Re: [PATCH] ceph: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-01 Thread Jeff Layton
On Mon, 2021-02-01 at 15:52 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./fs/ceph/debugfs.c:347:0-23: WARNING: congestion_kb_fops should be > defined with DEFINE_DEBUGFS_ATTRIBUTE. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- >  fs/ceph/debugfs.c

[PATCH] ceph: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-01-31 Thread Jiapeng Chong
Fix the following coccicheck warning: ./fs/ceph/debugfs.c:347:0-23: WARNING: congestion_kb_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- fs/ceph/debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/f