Re: [PATCH] can: mcp251x: Use dmam_alloc_coherent

2014-08-15 Thread Marc Kleine-Budde
On 08/02/2014 03:52 PM, Himangi Saraogi wrote: > This patch moves the data allocated using dma_alloc_coherent to the > corresponding managed interface and does away with the calls to free the > allocated memory in the probe and remove functions. > > Signed-off-by: Himangi Saraogi > Acked-by: Juli

Re: [PATCH] can: mcp251x: Use dmam_alloc_coherent

2014-08-05 Thread christian pellegrin
Hi all, BTW the reason that use of DMA is selectable by a parameter is that on some architectures (for example the venerable S3C24x0) the cost for its setup is so high that it doesn't make sense for smaller transfers. I absolutely agree with Stefano and Alexander, the SPI master driver is in the b

Re: [PATCH] can: mcp251x: Use dmam_alloc_coherent

2014-08-05 Thread Stefano Babic
Hi Himangi, On 02/08/2014 16:07, Alexander Shiyan wrote: > Sat, 2 Aug 2014 19:22:04 +0530 от Himangi Saraogi : >> This patch moves the data allocated using dma_alloc_coherent to the >> corresponding managed interface and does away with the calls to free the >> allocated memory in the probe and rem

Re: [PATCH] can: mcp251x: Use dmam_alloc_coherent

2014-08-02 Thread Alexander Shiyan
Sat, 2 Aug 2014 19:22:04 +0530 от Himangi Saraogi : > This patch moves the data allocated using dma_alloc_coherent to the > corresponding managed interface and does away with the calls to free the > allocated memory in the probe and remove functions. Just for information: On my opinion, all SPI DM

[PATCH] can: mcp251x: Use dmam_alloc_coherent

2014-08-02 Thread Himangi Saraogi
This patch moves the data allocated using dma_alloc_coherent to the corresponding managed interface and does away with the calls to free the allocated memory in the probe and remove functions. Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/can/spi/mcp251x.c | 16 -