Re: [PATCH] bug: Fix CONFIG_BUG=n BUG_ON()

2014-06-19 Thread josh
On Thu, Jun 19, 2014 at 07:51:42PM +0200, Bart Van Assche wrote: > On 06/19/14 19:21, j...@joshtriplett.org wrote: > > That's exactly what BUG_ON becomes if CONFIG_BUG=y, and that > > significantly increases kernel size; if you want that, set CONFIG_BUG=y. > > BUG_ON should continue to compile to n

Re: [PATCH] bug: Fix CONFIG_BUG=n BUG_ON()

2014-06-19 Thread Bart Van Assche
On 06/19/14 19:21, j...@joshtriplett.org wrote: > That's exactly what BUG_ON becomes if CONFIG_BUG=y, and that > significantly increases kernel size; if you want that, set CONFIG_BUG=y. > BUG_ON should continue to compile to nothing if CONFIG_BUG=n, or > CONFIG_BUG=n has no reason to exist. Hello

Re: [PATCH] bug: Fix CONFIG_BUG=n BUG_ON()

2014-06-19 Thread josh
On Thu, Jun 19, 2014 at 07:00:14PM +0200, Arnd Bergmann wrote: > On Thursday 19 June 2014 15:28:19 Bart Van Assche wrote: > > Patch "bug: Make BUG() always stop the machine" changed the > > behavior of BUG() with CONFIG_BUG=n from a no-op into an infinite > > loop. Modify the definition of BUG_ON()

Re: [PATCH] bug: Fix CONFIG_BUG=n BUG_ON()

2014-06-19 Thread Arnd Bergmann
On Thursday 19 June 2014 15:28:19 Bart Van Assche wrote: > Patch "bug: Make BUG() always stop the machine" changed the > behavior of BUG() with CONFIG_BUG=n from a no-op into an infinite > loop. Modify the definition of BUG_ON() accordingly such that the > behavior of BUG_ON(1) is identical to that

Re: [PATCH] bug: Fix CONFIG_BUG=n BUG_ON()

2014-06-19 Thread Josh Triplett
On Thu, Jun 19, 2014 at 03:28:19PM +0200, Bart Van Assche wrote: > Patch "bug: Make BUG() always stop the machine" changed the > behavior of BUG() with CONFIG_BUG=n from a no-op into an infinite > loop. Modify the definition of BUG_ON() accordingly such that the > behavior of BUG_ON(1) is identical

[PATCH] bug: Fix CONFIG_BUG=n BUG_ON()

2014-06-19 Thread Bart Van Assche
Patch "bug: Make BUG() always stop the machine" changed the behavior of BUG() with CONFIG_BUG=n from a no-op into an infinite loop. Modify the definition of BUG_ON() accordingly such that the behavior of BUG_ON(1) is identical to that of BUG(). Signed-off-by: Bart Van Assche Cc: Arnd Bergmann Cc