Re: [PATCH] btrfs: zstd ensure reclaim timer is properly cleaned up

2019-02-22 Thread Dennis Zhou
On Fri, Feb 22, 2019 at 02:17:41PM +0200, Nikolay Borisov wrote: > > > On 21.02.19 г. 22:25 ч., Dennis Zhou wrote: > > The timer function, zstd_reclaim_timer_fn(), reschedules itself under > > certain conditions. Switch to del_timer_sync() to ensure that the timer > > function hasn't rescheduled

Re: [PATCH] btrfs: zstd ensure reclaim timer is properly cleaned up

2019-02-22 Thread Nikolay Borisov
On 21.02.19 г. 22:25 ч., Dennis Zhou wrote: > The timer function, zstd_reclaim_timer_fn(), reschedules itself under > certain conditions. Switch to del_timer_sync() to ensure that the timer > function hasn't rescheduled itself. According to del_timer_sync it just waits for any concurrent invoca

[PATCH] btrfs: zstd ensure reclaim timer is properly cleaned up

2019-02-21 Thread Dennis Zhou
The timer function, zstd_reclaim_timer_fn(), reschedules itself under certain conditions. Switch to del_timer_sync() to ensure that the timer function hasn't rescheduled itself. Signed-off-by: Dennis Zhou --- fs/btrfs/zstd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/