Re: [PATCH] btrfs: fix error value in btrfs_get_extent

2020-08-11 Thread David Sterba
On Mon, Aug 03, 2020 at 12:50:31PM +0300, Nikolay Borisov wrote: > On 3.08.20 г. 12:39 ч., Nikolay Borisov wrote: > > On 3.08.20 г. 12:35 ч., Pavel Machek wrote: > >> btrfs_get_extent() sets variable ret, but out: error path expect error > >> to be in variable err. Fix that. > >> > >> Signed-off-by

Re: [PATCH] btrfs: fix error value in btrfs_get_extent

2020-08-11 Thread David Sterba
On Mon, Aug 03, 2020 at 11:35:06AM +0200, Pavel Machek wrote: > btrfs_get_extent() sets variable ret, but out: error path expect error > to be in variable err. Fix that. > > Signed-off-by: Pavel Machek (CIP) Thanks, patch queued for 5.9. > > --- > > Notice that patch introducing this problem i

Re: [PATCH] btrfs: fix error value in btrfs_get_extent

2020-08-03 Thread Nikolay Borisov
On 3.08.20 г. 12:39 ч., Nikolay Borisov wrote: > > > On 3.08.20 г. 12:35 ч., Pavel Machek wrote: >> btrfs_get_extent() sets variable ret, but out: error path expect error >> to be in variable err. Fix that. >> >> Signed-off-by: Pavel Machek (CIP) > > Good catch, this also needs: > > Fixes:

Re: [PATCH] btrfs: fix error value in btrfs_get_extent

2020-08-03 Thread Nikolay Borisov
On 3.08.20 г. 12:35 ч., Pavel Machek wrote: > btrfs_get_extent() sets variable ret, but out: error path expect error > to be in variable err. Fix that. > > Signed-off-by: Pavel Machek (CIP) Good catch, this also needs: Fixes: 6bf9e4bd6a27 ("btrfs: inode: Verify inode mode to avoid NULL point

[PATCH] btrfs: fix error value in btrfs_get_extent

2020-08-03 Thread Pavel Machek
btrfs_get_extent() sets variable ret, but out: error path expect error to be in variable err. Fix that. Signed-off-by: Pavel Machek (CIP) --- Notice that patch introducing this problem is on its way to 4.19.137-stable. diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 7befb7c12bd3..4aaa01