Re: [PATCH] btrfs: Fix missing close devices

2020-09-23 Thread Nikolay Borisov
On 21.09.20 г. 10:29 ч., qiang.zh...@windriver.com wrote: > From: Zqiang > > When the btrfs fill super error, we should first close devices and > then call deactivate_locked_super func to free fs_info. > > Signed-off-by: Zqiang > --- > fs/btrfs/super.c | 1 + > 1 file changed, 1 insertion(+

Re: 回复: 回复: [PATCH] btrfs: Fix missing close devices

2020-09-23 Thread Johannes Thumshirn
On 23/09/2020 08:03, Zhang, Qiang wrote: > Hello Johannes Thumshirn > > the crash happend in "snprintf(s->s_id, sizeof(s->s_id), "%pg", bdev)" in > btrfs_mount_root func, the "bdev" may be destroyed in btrfs_close_devices. > I think add btrfs_close_devices func before deactivate_locked_super i

回复: 回复: [PATCH] btrfs: Fix missing close devices

2020-09-22 Thread Zhang, Qiang
nel.org; linux-kernel@vger.kernel.org > 主题: Re: [PATCH] btrfs: Fix missing close devices > > On 21/09/2020 10:27, qiang.zh...@windriver.com wrote: >> From: Zqiang >> >> When the btrfs fill super error, we should first close devices and >> then call deactivate_locked_s

Re: [PATCH] btrfs: Fix missing close devices

2020-09-21 Thread Johannes Thumshirn
On 21/09/2020 13:00, qiang.zh...@windriver.com wrote: > From: Zqiang > > When the btrfs fill super error, we should first close devices and > then call deactivate_locked_super func to free fs_info. > > Signed-off-by: Zqiang > --- > fs/btrfs/super.c | 1 + > 1 file changed, 1 insertion(+) > >

[PATCH] btrfs: Fix missing close devices

2020-09-21 Thread qiang.zhang
From: Zqiang When the btrfs fill super error, we should first close devices and then call deactivate_locked_super func to free fs_info. Signed-off-by: Zqiang --- fs/btrfs/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 8840a4fa81eb..3bfd54e

Re: 回复: [PATCH] btrfs: Fix missing close devices

2020-09-21 Thread Johannes Thumshirn
.org > 主题: Re: [PATCH] btrfs: Fix missing close devices > > On 21/09/2020 10:27, qiang.zh...@windriver.com wrote: >> From: Zqiang >> >> When the btrfs fill super error, we should first close devices and >> then call deactivate_locked_super func to free fs_info. >&g

回复: [PATCH] btrfs: Fix missing close devices

2020-09-21 Thread Zhang, Qiang
发件人: Johannes Thumshirn 发送时间: 2020年9月21日 16:52 收件人: Zhang, Qiang; c...@fb.com; jo...@toxicpanda.com; dste...@suse.com 抄送: linux-bt...@vger.kernel.org; linux-kernel@vger.kernel.org 主题: Re: [PATCH] btrfs: Fix missing close devices On 21/09/2020 10:27

Re: [PATCH] btrfs: Fix missing close devices

2020-09-21 Thread Johannes Thumshirn
On 21/09/2020 10:27, qiang.zh...@windriver.com wrote: > From: Zqiang > > When the btrfs fill super error, we should first close devices and > then call deactivate_locked_super func to free fs_info. > > Signed-off-by: Zqiang > --- > fs/btrfs/super.c | 1 + > 1 file changed, 1 insertion(+) > >

[PATCH] btrfs: Fix missing close devices

2020-09-21 Thread qiang.zhang
From: Zqiang When the btrfs fill super error, we should first close devices and then call deactivate_locked_super func to free fs_info. Signed-off-by: Zqiang --- fs/btrfs/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 8840a4fa81eb..3bfd54e