[PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-19 Thread Borislav Petkov
From: Borislav Petkov When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get drivers/built-in.o: In function `brcms_led_unregister': (.text+0x351aca): undefined reference to `led_classdev_unregister' drivers/built-in.o: In function `brcms_led_register': (.text+0x351c65): undefined refer

Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-19 Thread Arend van Spriel
On 11/19/2013 12:32 AM, Borislav Petkov wrote: On Mon, Nov 18, 2013 at 11:19:08PM +0100, Arend van Spriel wrote: what about: config BRCMSMAC tristate "Broadcom IEEE802.11n PCIe SoftMAC WLAN driver" depends on MAC80211 depends on BCMA_POSSIBLE + select LEDS_CLASS

Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-18 Thread Borislav Petkov
On Mon, Nov 18, 2013 at 11:19:08PM +0100, Arend van Spriel wrote: > what about: > > config BRCMSMAC > tristate "Broadcom IEEE802.11n PCIe SoftMAC WLAN driver" > depends on MAC80211 > depends on BCMA_POSSIBLE > + select LEDS_CLASS if BCMA_DRIVER_GPIO > select BCMA

Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-18 Thread Arend van Spriel
On 11/18/2013 09:40 PM, Borislav Petkov wrote: On Mon, Nov 18, 2013 at 02:32:50PM +0100, Borislav Petkov wrote: On Mon, Nov 18, 2013 at 12:58:58PM +0100, Rafał Miłecki wrote: Borislav: I think I didn't get your original patch. Forget it, I'll send a better one later. Ok, let's try another o

Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-18 Thread Borislav Petkov
On Mon, Nov 18, 2013 at 02:32:50PM +0100, Borislav Petkov wrote: > On Mon, Nov 18, 2013 at 12:58:58PM +0100, Rafał Miłecki wrote: > > Borislav: I think I didn't get your original patch. > > Forget it, I'll send a better one later. Ok, let's try another one. I've done it with depends but we probab

Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-18 Thread Borislav Petkov
On Mon, Nov 18, 2013 at 12:58:58PM +0100, Rafał Miłecki wrote: > Borislav: I think I didn't get your original patch. Forget it, I'll send a better one later. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line

Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-18 Thread Rafał Miłecki
2013/11/17 Arend van Spriel : > On 11/17/13 14:37, Borislav Petkov wrote: >> >> From: Borislav Petkov >> >> When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get >> >> drivers/built-in.o: In function `brcms_led_unregister': >> (.text+0x351aca): undefined reference to `led_classdev_unregis

Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-17 Thread Borislav Petkov
On Sun, Nov 17, 2013 at 10:31:07PM +0100, Arend van Spriel wrote: > Wouldn't it be better to fix it in brcmsmac. You're right, BCMA_DRIVER_GPIO doesn't need LEDS_CLASS. So, the only solution I can think of right now is below, maybe adding a hidden config symbol CONFIG_BRCMSMAC_LEDS which depends

Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-17 Thread Arend van Spriel
On 11/17/13 14:37, Borislav Petkov wrote: From: Borislav Petkov When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get drivers/built-in.o: In function `brcms_led_unregister': (.text+0x351aca): undefined reference to `led_classdev_unregister' drivers/built-in.o: In function `brcms_led_r