Re: [PATCH] branch tracer: fix freak link error

2016-02-16 Thread Arnd Bergmann
On Monday 15 February 2016 15:26:39 Steven Rostedt wrote: > On Mon, 15 Feb 2016 21:15:39 +0100 > Arnd Bergmann wrote: > > > Do you also want to add a 'Cc: sta...@vger.kernel.org' tag? > > > > I currently have this in the Tags: > > Acked-by: Nicolas Pitre > Fixes: ab3c9c686e22 ("branch

Re: [PATCH] branch tracer: fix freak link error

2016-02-15 Thread Steven Rostedt
On Mon, 15 Feb 2016 21:15:39 +0100 Arnd Bergmann wrote: > Do you also want to add a 'Cc: sta...@vger.kernel.org' tag? > I currently have this in the Tags: Acked-by: Nicolas Pitre Fixes: ab3c9c686e22 ("branch tracer, intel-iommu: fix build with CONFIG_BRANCH_TRACER=y") Cc: sta...@

Re: [PATCH] branch tracer: fix freak link error

2016-02-15 Thread Arnd Bergmann
On Monday 15 February 2016 12:47:46 Steven Rostedt wrote: > On Fri, 12 Feb 2016 22:26:42 +0100 > Arnd Bergmann wrote: > > > In my randconfig tests, I came across a bug that involves several > > components: > > > > > > [..] > > > > > This patch avoids the problem by changing __trace_if() to ch

Re: [PATCH] branch tracer: fix freak link error

2016-02-15 Thread Steven Rostedt
On Fri, 12 Feb 2016 22:26:42 +0100 Arnd Bergmann wrote: > In my randconfig tests, I came across a bug that involves several > components: > > [..] > > This patch avoids the problem by changing __trace_if() to check > whether the condition is known at compile-time to be nonzero, rather > than

Re: [PATCH] branch tracer: fix freak link error

2016-02-12 Thread Arnd Bergmann
On Friday 12 February 2016 17:12:37 Steven Rostedt wrote: > On Fri, 12 Feb 2016 22:52:10 +0100 > Arnd Bergmann wrote: > > > On Friday 12 February 2016 22:49:07 Arnd Bergmann wrote: > > > Now I have to check if it does anything to the spurious > > > "maybe-uninitialized" > > > warnings that I saw

Re: [PATCH] branch tracer: fix freak link error

2016-02-12 Thread Steven Rostedt
On Fri, 12 Feb 2016 22:52:10 +0100 Arnd Bergmann wrote: > On Friday 12 February 2016 22:49:07 Arnd Bergmann wrote: > > Now I have to check if it does anything to the spurious > > "maybe-uninitialized" > > warnings that I saw creeping in with PROFILE_ALL_BRANCHES. My guess is > > that it doesn't

Re: [PATCH] branch tracer: fix freak link error

2016-02-12 Thread Arnd Bergmann
On Friday 12 February 2016 22:49:07 Arnd Bergmann wrote: > Now I have to check if it does anything to the spurious "maybe-uninitialized" > warnings that I saw creeping in with PROFILE_ALL_BRANCHES. My guess is > that it doesn't fix them (I submitted a patch to turn off those > warnings today when P

Re: [PATCH] branch tracer: fix freak link error

2016-02-12 Thread Arnd Bergmann
On Friday 12 February 2016 16:45:03 Nicolas Pitre wrote: > > It is certainly a worthwhile workaround if it solves all the known > cases. > > Acked-by: Nicolas Pitre > > This trick doesn't work with the test case I produced to demonstrate > this bug though. So we might be affected again in th

Re: [PATCH] branch tracer: fix freak link error

2016-02-12 Thread Nicolas Pitre
On Fri, 12 Feb 2016, Arnd Bergmann wrote: > In my randconfig tests, I came across a bug that involves several > components: > > * gcc-4.9 through at least 5.3 > * CONFIG_GCOV_PROFILE_ALL enabling -fprofile-arcs for all files > * CONFIG_PROFILE_ALL_BRANCHES overriding every if() > * The optimized

[PATCH] branch tracer: fix freak link error

2016-02-12 Thread Arnd Bergmann
In my randconfig tests, I came across a bug that involves several components: * gcc-4.9 through at least 5.3 * CONFIG_GCOV_PROFILE_ALL enabling -fprofile-arcs for all files * CONFIG_PROFILE_ALL_BRANCHES overriding every if() * The optimized implementation of do_div() that tries to replace a libr