Re: [PATCH] bpf: hide do_bpf_send_signal when unused

2019-06-24 Thread Yonghong Song
On 6/17/19 5:18 PM, Steven Rostedt wrote: > On Mon, 17 Jun 2019 16:27:33 -0700 > Alexei Starovoitov wrote: > >> On Mon, Jun 17, 2019 at 4:13 PM Matt Mullins wrote: The bug (really just a warning) reported is exactly here. >>> >>> I don't think bpf_send_signal is tied to modules at al

Re: [PATCH] bpf: hide do_bpf_send_signal when unused

2019-06-17 Thread Steven Rostedt
On Mon, 17 Jun 2019 16:27:33 -0700 Alexei Starovoitov wrote: > On Mon, Jun 17, 2019 at 4:13 PM Matt Mullins wrote: > > > > > > The bug (really just a warning) reported is exactly here. > > > > I don't think bpf_send_signal is tied to modules at all; > > send_signal_irq_work_init and the corres

Re: [PATCH] bpf: hide do_bpf_send_signal when unused

2019-06-17 Thread Alexei Starovoitov
On Mon, Jun 17, 2019 at 4:13 PM Matt Mullins wrote: > > > > The bug (really just a warning) reported is exactly here. > > I don't think bpf_send_signal is tied to modules at all; > send_signal_irq_work_init and the corresponding initcall should be > moved outside that #ifdef. right. I guess send_

Re: [PATCH] bpf: hide do_bpf_send_signal when unused

2019-06-17 Thread Matt Mullins
On Mon, 2019-06-17 at 19:09 -0400, Steven Rostedt wrote: > On Mon, 17 Jun 2019 08:26:29 -0700 > Alexei Starovoitov wrote: > > > On Mon, Jun 17, 2019 at 5:59 AM Arnd Bergmann wrote: > > > > > > When CONFIG_MODULES is disabled, this function is never called: > > > > > > kernel/trace/bpf_trace.c:

Re: [PATCH] bpf: hide do_bpf_send_signal when unused

2019-06-17 Thread Steven Rostedt
On Mon, 17 Jun 2019 08:26:29 -0700 Alexei Starovoitov wrote: > On Mon, Jun 17, 2019 at 5:59 AM Arnd Bergmann wrote: > > > > When CONFIG_MODULES is disabled, this function is never called: > > > > kernel/trace/bpf_trace.c:581:13: error: 'do_bpf_send_signal' defined but > > not used [-Werror=unus

Re: [PATCH] bpf: hide do_bpf_send_signal when unused

2019-06-17 Thread Alexei Starovoitov
On Mon, Jun 17, 2019 at 5:59 AM Arnd Bergmann wrote: > > When CONFIG_MODULES is disabled, this function is never called: > > kernel/trace/bpf_trace.c:581:13: error: 'do_bpf_send_signal' defined but not > used [-Werror=unused-function] hmm. it should work just fine without modules. the bug is som

[PATCH] bpf: hide do_bpf_send_signal when unused

2019-06-17 Thread Arnd Bergmann
When CONFIG_MODULES is disabled, this function is never called: kernel/trace/bpf_trace.c:581:13: error: 'do_bpf_send_signal' defined but not used [-Werror=unused-function] Add another #ifdef around it. Fixes: 8b401f9ed244 ("bpf: implement bpf_send_signal() helper") Signed-off-by: Arnd Bergmann